feat: add support for biometric login#45
Merged
freekvandeven merged 1 commit intomasterfrom Apr 17, 2025
Merged
Conversation
Quirille
reviewed
Apr 16, 2025
lib/src/config/login_options.dart
Outdated
| /// Allow the user to login with biometrics even if they have no biometrics | ||
| /// set up on their device. This will use pincode or other authentication | ||
| /// methods | ||
| final bool allowBiometricLoginWithoutBiometrics; |
There was a problem hiding this comment.
Please change the name, this one is terrible.
allowPinAlternative or whatever you want, then explain why in the doc comment
Quirille
reviewed
Apr 16, 2025
Quirille
reviewed
Apr 16, 2025
| Future<void> authenticate(LoginOptions loginOptions) async { | ||
| try { | ||
| if (!await _localAuth.isDeviceSupported()) { | ||
| loginOptions.onBiometricsError?.call(); |
There was a problem hiding this comment.
this is not the same situation as !didAuthenticate.
Quirille
reviewed
Apr 16, 2025
Quirille
reviewed
Apr 16, 2025
tobiasleijs
suggested changes
Apr 16, 2025
freekvandeven
force-pushed
the
feature/biometric-login
branch
from
14e6288 to
93e4e46
Compare
Quirille
reviewed
Apr 17, 2025
freekvandeven
force-pushed
the
feature/biometric-login
branch
from
93e4e46 to
9cc5e16
Compare
Quirille
approved these changes
Apr 17, 2025
tobiasleijs
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.