fix: Vite build cache issues around ESM modules and style leakage#1156
Open
rkaraivanov wants to merge 1 commit intocopilot/create-vite-samples-browserfrom
Open
fix: Vite build cache issues around ESM modules and style leakage#1156rkaraivanov wants to merge 1 commit intocopilot/create-vite-samples-browserfrom
rkaraivanov wants to merge 1 commit intocopilot/create-vite-samples-browserfrom
Conversation
- Modifed all samples to export a function that creates the sample, instead of exporting the sample directly. This allows us to create a new instance of the sample for each run, which is necessary to avoid caching issues with Vite. - Tag default styles and remove additional style tags from the document head to prevent style leakage between samples.
ChronosSF
requested changes
Feb 13, 2026
| } | ||
|
|
||
| new Sample(); | ||
| export function initialize() { |
Member
There was a problem hiding this comment.
The separate samples still have to be "initialized" in some way, otherwise the business logic is not executed. They are used for Codesandbox and this will make them unusable.
Member
There was a problem hiding this comment.
e.g.
cd ./samples/grids/advanced-filtering-options/
npm install
npm run startshould bring up a working sample and it's doesn't.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifed all samples to export a function that creates the sample, instead of exporting the sample directly. This allows us to create a new instance of the sample for each run, which is necessary to avoid caching issues with Vite.
Tag default styles and remove additional style tags from the document head to prevent style leakage between samples.