Skip to content

Add wake factor computation (loss and kick factors) with postprocessing function and test in my_test folder#78

Open
saraadastan wants to merge 5 commits into
ImpedanCEI:mainfrom
saraadastan:feature/wake-factors
Open

Add wake factor computation (loss and kick factors) with postprocessing function and test in my_test folder#78
saraadastan wants to merge 5 commits into
ImpedanCEI:mainfrom
saraadastan:feature/wake-factors

Conversation

@saraadastan

Copy link
Copy Markdown

📝 Pull Request Summary

This PR adds a new postprocessing feature to compute wake factors from simulation results.

Specifically, it introduces the computation of:

  • Longitudinal loss factor
  • Transverse kick factors (kx, ky)

The implementation is consistent with the Wakis workflow by using WakeSolver.load_results() for reading data, ensuring compatibility with MPI runs.

🔧 Changes Made

  • Added compute_wake_factors function in postprocessing module
  • Implemented time-domain computation of loss and kick factors
  • Integrated reading of results using WakeSolver.load_results()
  • Added test script/example to validate the functionality

✅ Checklist

  • Code follows the project's style and guidelines
  • Added tests for new functionality
  • Updated documentation (optional for now unless you added docs)
  • Verified that changes do not break existing functionality

📌 Related Issues / PRs

N/A

@elenafuengar elenafuengar self-assigned this Apr 28, 2026
@elenafuengar elenafuengar added enhancement New feature or request good first issue Good for newcomers labels Apr 28, 2026
@elenafuengar elenafuengar self-requested a review April 28, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants