Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the WASM→Rocq (Coq) code generator to also emit a skeleton theorem stating module validity, and extends the generated Rocq imports accordingly (assuming the referenced WasmCertCoq-Essence branch provides the needed verifier definitions).
Changes:
- Add
verifierto the generatedFrom Wasm Require Import ...line. - Append a generated
ValidModuletheorem stub (valid_{module_name}) after the module definition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Georgii Plotnikov <accembler@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
|
I have introduced the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Rocq code generation, I have now configured the system to output the Rocq theorems that the user should prove.
This assumes that the
yoshihiro503@wasm-verifierbranch ofWasmCertCoq-Essenceis being used.Since preparations on the wasm-verifier interfaces are not yet complete, this PR is a draft.