Skip to content

fix: pin versions to fix mdbook build error#106

Merged
jeffabailey merged 1 commit intomainfrom
fix-mdbook
Feb 28, 2026
Merged

fix: pin versions to fix mdbook build error#106
jeffabailey merged 1 commit intomainfrom
fix-mdbook

Conversation

@jeffabailey
Copy link
Collaborator

No description provided.

@jeffabailey jeffabailey requested a review from a team as a code owner November 27, 2025 18:19
@dellagustin-sap
Copy link
Contributor

dellagustin-sap commented Nov 28, 2025

Hi @jeffabailey , thank you for the change.
I'm not able to test it the moment, but upon inspection, it looks ok.

A have a question though, there seems to be a functional change to the giscus with giscus.loading = "lazy". This is not mentioned in the PR description. Could you please explain this change?

@jeffabailey
Copy link
Collaborator Author

It lazy-loads the comment section to reduce initial page load time.

Loading of the comments will be deferred until the user scrolls near the comments container. This is done by adding loading="lazy" to the <iframe> element.

https://giscus.app/

@jeffabailey jeffabailey merged commit 290b50d into main Feb 28, 2026
3 checks passed
@jeffabailey jeffabailey deleted the fix-mdbook branch February 28, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants