Skip to content

Conversation

@roninsightrx
Copy link
Contributor

Implements #17

roninsightrx and others added 18 commits September 23, 2025 04:38
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
@roninsightrx roninsightrx changed the base branch from main to vpc September 26, 2025 23:13
Base automatically changed from vpc to main September 30, 2025 19:22
#'
#' @export
print.mipdeval_results <- function(x, ...) {
if(is.null(x$results)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change, but I noticed this prints only NULLs when there is no forecasting data.

* add ofv and ss

* add test

* Update R/run_eval_core.R

Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>

---------

Co-authored-by: Michael McCarthy <51542091+mccarthy-m-g@users.noreply.github.com>
Copy link
Collaborator

@mccarthy-m-g mccarthy-m-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm!

@roninsightrx roninsightrx merged commit 1b4a2be into main Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants