Skip to content

Conversation

@dominic-irx
Copy link

@dominic-irx dominic-irx commented Dec 2, 2025

This PR now does two things:

  1. skips an encounter in case of fit error
  2. Adds option to reduce precision of fit, to minimize fit errors (reltol in .fit_options).

@dominic-irx dominic-irx changed the title RXR-2888: add dose compartments input [WIP] RXR-2888: add dose compartments input Dec 2, 2025
@dominic-irx dominic-irx changed the title [WIP] RXR-2888: add dose compartments input RXR-2888: skip in case of fit error and add options to reduce precision Dec 3, 2025
@dominic-irx dominic-irx marked this pull request as ready for review December 3, 2025 22:53
@mccarthy-m-g
Copy link
Collaborator

@dominic-irx For the .fit_options argument, could we make it take a fit_options() function as input like we're doing for .stats_summ_options (stats_summ_options()) and .vpc_options (vpc_options ()).

The benefit is that we get clearer documentation on what's available, and we get input validation with nice error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants