Improved error checking of snprintf - #19
Merged
hjmjohnson merged 1 commit intoJan 12, 2026
Merged
Conversation
2 tasks
Collaborator
Author
|
@issakomi care to review? I haven't actually tested this yet, but wanted to share... |
Collaborator
Author
|
OK, I tested this by trying a few commands to |
Collaborator
Author
|
@issakomi friendly ping... |
Member
|
Thank you. I noticed this while looking through the Nifti update. I didn't test. |
Although usually snprintf return values are ignored, there were a few places that bothered to check, and a recent change stored the return value in an unsigned, making it hard to check to a negative result (error condition). This reworks the function a little bit to improve error checking.
seanm
force-pushed
the
snprintf-error-checks
branch
from
January 2, 2026 01:33
4574d05 to
bacab0f
Compare
Collaborator
Author
|
@hjmjohnson @issakomi I think we can merge this now? |
hjmjohnson
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although usually snprintf return values are ignored, there were a few places that bothered to check, and a recent change stored the return value in an unsigned, making it hard to check to a negative result (error condition).
This reworks the function a little bit to improve error checking.