Skip to content

Disable assertions in release builds for SPM targets #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DesmondLime wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

Disable assertions in release builds for SPM targets #1661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aae8ba6
Disable assertions in release builds for SPM targets
DesmondLime Jul 24, 2026
c61c35f
Add CHANGELOG entry for the SPM release assertion fix
DesmondLime Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ The changelog for `IGListKit`. Also see the [releases](https://github.com/instag

### Fixes

- Assertions are no longer compiled into release builds when integrating via Swift Package Manager. `NS_BLOCK_ASSERTIONS` is now defined for the `IGListDiffKit` and `IGListKit` targets in the release configuration, matching the behaviour of the Xcode project and CocoaPods. [Desmond Zhong](https://github.com/DesmondLime)

- Fixed public compilation failure on macOS (SPM, CocoaPods) by conditionally importing METAUIKitBridge only when available. [Cameron Roth](https://github.com/camroth)

- An infinite recursion crash when VoiceOver is enabled and `scrollViewDelegate` or `collectionViewDelegate` is set to the adapter's own `UICollectionView`. [Cameron Roth](https://github.com/camroth) [(#1658)](https://github.com/Instagram/IGListKit/issues/1658)
Expand Down
6 changes: 4 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,15 @@ let package = Package(
.target(
name: "IGListDiffKit",
path: "spm/Sources/IGListDiffKit",
publicHeadersPath: "include"
publicHeadersPath: "include",
cSettings: [.define("NS_BLOCK_ASSERTIONS", .when(configuration: .release))]
),
.target(
name: "IGListKit",
dependencies: ["IGListDiffKit"],
path: "spm/Sources/IGListKit",
publicHeadersPath: "include"
publicHeadersPath: "include",
cSettings: [.define("NS_BLOCK_ASSERTIONS", .when(configuration: .release))]
),
.target(
name: "IGListSwiftKit",
Expand Down