Skip to content

chore/fix: compare patch version in MinecraftVersion#4877

Merged
NotMyFault merged 1 commit into
mainfrom
chore/minecraftVersions
Jun 4, 2026
Merged

chore/fix: compare patch version in MinecraftVersion#4877
NotMyFault merged 1 commit into
mainfrom
chore/minecraftVersions

Conversation

@PierreSchwang

@PierreSchwang PierreSchwang commented May 25, 2026

Copy link
Copy Markdown
Member

Overview

Follow-up to #4871

Description

I've added a field for the patch version, but did not compare it yet (added afterwards, as I did not know that the newer versions actually have patch versions). Given patch versions are not relevant (yet), the current code is not inherently broken - just not fully correct.

  • Added documentation on how (and if) patch version parts are provided.
  • Use compareTo for object comparisions.
  • Validate version parts (non-negative).
  • Added basic tests for comparison methods (compareTo is implicitly tested).

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@PierreSchwang PierreSchwang requested a review from a team as a code owner May 25, 2026 20:13
@NotMyFault NotMyFault merged commit 405157f into main Jun 4, 2026
8 checks passed
@NotMyFault NotMyFault deleted the chore/minecraftVersions branch June 4, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants