Refactor scheduler and engine.py #4163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimoire
changed the title
lvhan028
reviewed
Dec 10, 2025
Comment on lines
+101
to
+104
| def activate(self): | ||
| """From STOPPED to WAITING.""" | ||
| assert self.seq.num_token_ids > 0 | ||
| self.to_state(WaitingState) |
Collaborator
There was a problem hiding this comment.
In what case a stopped seq can be activate again?
Collaborator
Author
There was a problem hiding this comment.
second round chat
lvhan028
reviewed
Dec 10, 2025
| self.seq = seq | ||
| self.scheduler = scheduler | ||
|
|
||
| def to_state(self, new_state): |
Collaborator
There was a problem hiding this comment.
For better readability, consider using state_cls instead of new_state since it's a class, not an instance.
lvhan028
reviewed
Dec 10, 2025
RunningLeon
reviewed
Dec 11, 2025
lvhan028
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.