Skip to content

Add simpleRewards reproducer from cardano-db-sync and migrate TwoPools example to an ImpTest#5529

Merged
Lucsanszky merged 4 commits intomasterfrom
ldan/shelley-rewcalc-investigation
Apr 7, 2026
Merged

Add simpleRewards reproducer from cardano-db-sync and migrate TwoPools example to an ImpTest#5529
Lucsanszky merged 4 commits intomasterfrom
ldan/shelley-rewcalc-investigation

Conversation

@Lucsanszky
Copy link
Copy Markdown
Contributor

@Lucsanszky Lucsanszky commented Jan 20, 2026

Description

See #5477 for discussion.
Resolves #5593

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Lucsanszky Lucsanszky force-pushed the ldan/shelley-rewcalc-investigation branch 9 times, most recently from 322f2ac to 72ee85a Compare March 23, 2026 12:36
@Lucsanszky Lucsanszky marked this pull request as ready for review March 23, 2026 12:38
@Lucsanszky Lucsanszky requested a review from a team as a code owner March 23, 2026 12:38
@Lucsanszky Lucsanszky changed the title Reward calculation investigation Add simpleRewards reproducer from cardano-db-sync and migrate TwoPools example to an ImpTest Mar 23, 2026
@Lucsanszky Lucsanszky force-pushed the ldan/shelley-rewcalc-investigation branch 2 times, most recently from 5c3bfec to ad3b798 Compare March 30, 2026 16:10
@Lucsanszky Lucsanszky force-pushed the ldan/shelley-rewcalc-investigation branch 3 times, most recently from c714ff7 to d123542 Compare April 2, 2026 20:38
Copy link
Copy Markdown
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you.
Just a few minor suggestions

Comment thread eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/Imp/PoolSpec.hs Outdated
Comment thread eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/Imp/PoolSpec.hs Outdated
Comment thread eras/babbage/impl/testlib/Test/Cardano/Ledger/Babbage/Imp/PoolSpec.hs Outdated
Comment thread eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Imp/PoolSpec.hs Outdated
Comment thread eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Imp/PoolSpec.hs Outdated
Comment thread eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Imp/PoolSpec.hs Outdated
@Lucsanszky Lucsanszky force-pushed the ldan/shelley-rewcalc-investigation branch from d123542 to 90ba9c3 Compare April 3, 2026 13:45
@Lucsanszky Lucsanszky enabled auto-merge April 3, 2026 13:48
@Lucsanszky Lucsanszky force-pushed the ldan/shelley-rewcalc-investigation branch from 90ba9c3 to 9379257 Compare April 7, 2026 19:11
This also requires setting the decentralisation parameter `ppD` to `< 1`
so pools can produce blocks as well. We set it to `minBound` which means
that the network is full decentralised.
@Lucsanszky Lucsanszky force-pushed the ldan/shelley-rewcalc-investigation branch from 9379257 to 10659fd Compare April 7, 2026 20:00
@Lucsanszky Lucsanszky merged commit c96ceb0 into master Apr 7, 2026
151 of 152 checks passed
@Lucsanszky Lucsanszky deleted the ldan/shelley-rewcalc-investigation branch April 7, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert TwoPools cardano-ledger-shelley-test to an ImpTest

2 participants