new tracing system: networking addjustments #6388
Merged
+57
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/new-tracing-system
branch
from
9f96675 to
0ca2c18
Compare
jutaro
requested changes
Dec 5, 2025
Contributor
jutaro
left a comment
jutaro
left a comment
There was a problem hiding this comment.
Just two changes, I will push a commit that fixed these tow issues. Otherwise it looks good to me.
| ] | ||
|
|
||
| instance MetaTrace (FetchDecision [Point header]) where | ||
| namespaceFor (Left FetchDeclineChainIntersectionTooDeep) |
Contributor
There was a problem hiding this comment.
To make this fully functional namespaces needs more, so I propose to do a simple dispatch here on the runtime object
Contributor
Author
There was a problem hiding this comment.
Do you mean that each constructor needs to have its own namespace under ["Decline"]?
jutaro
added a commit
that referenced
this pull request
Dec 5, 2025
jutaro
approved these changes
Dec 5, 2025
Contributor
jutaro
left a comment
jutaro
left a comment
There was a problem hiding this comment.
LGTM
PS: I have not checked if standard configurations have to be adopted
Use the same severities in the new tracing system as in the old one.
* removed unused namespace "ImpossibleConnection" * set severity of `ConnectionManagerCounters` to `Info` (as in the legacy tracing system)
Using type aliases exposed by `cardano-diffusion` package.
coot
force-pushed
the
coot/new-tracing-system
branch
from
c9fb720 to
250b290
Compare
Contributor
Author
|
I rebased the PR on top of master. |
jutaro
force-pushed
the
coot/new-tracing-system
branch
from
2bfa9be to
a6a513c
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
new tracing system: networking addjustments
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the new tracing system behave more like the old one:
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.