Removal of buildkite and obsolute documents#144
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes remaining Buildkite integration from the sync test suite and CI scaffolding, shifting artifact handling and snapshot state passing to CI-agnostic mechanisms (GitHub Actions artifact upload + local state files).
Changes:
- Remove Buildkite-specific metadata and artifact upload helpers, plus Buildkite pipeline/workflow triggers.
- Persist snapshot creation metadata to
sync_session_state.jsonand read it back during local snapshot restoration. - Update docs and CI environment detection to reflect non-Buildkite flows.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sync_tests/utils/db_sync/init.py | Renames Buildkite-derived timeout variable and removes Buildkite metadata wrappers. |
| sync_tests/utils/artifacts/init.py | Removes Buildkite agent integration; keeps artifacts local/for CI collection. |
| sync_tests/tests/test_snapshot_creation.py | Writes snapshot metadata to sync_session_state.json for later restoration steps. |
| sync_tests/tests/test_local_snapshot_restoration.py | Reads snapshot metadata from JSON state file instead of Buildkite metadata; adds fixture dependency ordering. |
| sync_tests/scripts/postgres-start.sh | Removes Buildkite-specific wording in socket path length comment. |
| README.md | Removes obsolete document index and updates CI artifact description for GitHub Actions. |
| .github/workflows/weekly_node_sync_test.yaml | Removes workflow that triggered Buildkite pipeline (file deleted). |
| .github/workflows/node_sync_test_genesis.yaml | Removes workflow that triggered Buildkite pipeline (file deleted). |
| .github/workflows/node_mainnet_tx_count_per_epoch.yaml | Removes unused Buildkite secret from environment. |
| .buildkite/node-db-sync.yml | Removes Buildkite pipeline definition (file deleted). |
| .buildkite/node_sync_tests.yml | Removes Buildkite pipeline definition (file deleted). |
| .buildkite/db_sync_full_sync.yml | Removes Buildkite pipeline definition (file deleted). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| from _pytest.fixtures import FixtureRequest | ||
|
|
||
| from sync_tests.tests.conftest import SyncContext | ||
| from sync_tests.tests.test_snapshot_creation import snapshot_created # noqa: F401 |
| def local_restoration_result( | ||
| request: FixtureRequest, | ||
| sync_context: SyncContext, | ||
| snapshot_created: dict[str, tp.Any], # noqa: ARG001,F811 |
Comment on lines
+86
to
+88
| with open(snapshot_state_file, encoding="utf-8") as state_fh: | ||
| snapshot_data = json.load(state_fh) | ||
| snapshot_file = snapshot_data["snapshot_file"] |
local_restoration_result no longer requires the snapshot_created fixture. That dependency forced a full node sync and snapshot creation on every restoration only test run, defeating the point of testing restoration in isolation from a snapshot already made in an earlier run. Restoration now only reads the metadata file written by a prior snapshot creation run and fails clearly if it is missing or malformed, which also removes the noqa markers Copilot flagged as unneeded once the fixture import is gone.
mkoura
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of buildkite and obsolute documents