Skip to content

Metatheory: add Value built-in type with postulated functions#7832

Open
basetunnel wants to merge 6 commits into
masterfrom
basetunnel/metatheory-value
Open

Metatheory: add Value built-in type with postulated functions#7832
basetunnel wants to merge 6 commits into
masterfrom
basetunnel/metatheory-value

Conversation

@basetunnel

Copy link
Copy Markdown
Collaborator

Adds a postulated type Value and corresponding postulated built-in functions. Fixes fixes https://github.com/IntersectMBO/plutus-private/issues/1796.

I've also refactored the pattern matching of convertModel, while I was changing it to work for the new built-in functions. convertModel had a catch-all clause that broke the Agda CEK machine after a new RawModel constructor was added (which is used by one of the value built-ins). Such problems should from now on be caught by the coverage checker.

This also fixes https://github.com/IntersectMBO/plutus-private/issues/2283.

@basetunnel basetunnel requested review from ana-pantilie and kwxm July 5, 2026 14:28

@ana-pantilie ana-pantilie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but I'm concerned about the budget changes and there's also one potentially problematic change I've pointed out in the review.

Could the budget changes be explained by the fact that they were marked as "failing" and they weren't checked by CI? I know we've made multiple changes to the cost model between first adding the tests and this PR. Or did something in this PR trigger the modifications?

Comment thread plutus-metatheory/src/Algorithmic/ReductionEC/Determinism.lagda.md
Comment thread plutus-metatheory/src/Algorithmic/ReductionEC.lagda.md
Comment thread plutus-metatheory/src/Cost/Model.lagda.md
Comment thread plutus-metatheory/src/Raw.lagda.md
@basetunnel

Copy link
Copy Markdown
Collaborator Author

but I'm concerned about the budget changes

Could the budget changes be explained by the fact that they were marked as "failing" and they weren't checked by CI? I know we've made multiple changes to the cost model between first adding the tests and this PR.

That's what I assumed too, I'll try to see if I can verify that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants