fix(lvgl): install lv_version.h into lvgl include dir#2
Merged
Conversation
Agent-Logs-Url: https://github.com/maikebing/PowerfulCrossCompilationToolchain/sessions/7012f9ea-d8af-43c9-9b3f-197c37121cc2 Co-authored-by: maikebing <3445167+maikebing@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
maikebing
April 10, 2026 10:41
View session
There was a problem hiding this comment.
Pull request overview
This PR fixes LVGL v9.5 header installation so that lvgl.h’s relative include of lv_version.h resolves correctly from the installed include directory layout ($PCCT_INCLUDEDIR/lvgl).
Changes:
- Installs
lv_version.hinto$PCCT_INCLUDEDIR/lvgl/alongsidelvgl.handlv_conf.h - Adds a top-level symlink
$PCCT_INCLUDEDIR/lv_version.h -> lvgl/lv_version.hto match existinglvgl.h/lv_conf.hsymlink behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LVGL v9.5's
lvgl.hdoes#include "lv_version.h"(relative lookup), so it must exist at$PCCT_INCLUDEDIR/lvgl/lv_version.h. The file lives in the LVGL root — not undersrc/— so thecp -R src/step never placed it there, causing a missing header at compile time.Changes (
sources/rebuildlvgl.sh)lv_version.halongsidelvgl.handlv_conf.hinto$PCCT_INCLUDEDIR/lvgl/$PCCT_INCLUDEDIR/lv_version.h → lvgl/lv_version.h, consistent with the existing symlinks forlvgl.handlv_conf.h