Conversation
This should allow them to work on PyPI.
| pytest-cov ~= 2.6.1 | ||
| pytest-randomly ~= 1.2.3 | ||
| python-kadmin ~= 0.1.2 | ||
| git+https://github.com/twAlexM/python-kadmin.git@7b89b1880ad09b753c8366dad114b79674d00597 |
There was a problem hiding this comment.
maybe we should just fork this project?
There was a problem hiding this comment.
Ya... This definitely feels like a hack. I'm not too worried about it since it's test code, but if that fork ever goes away, it will break anything that ever depended on it (e.g. we won't be able to rerun old Travis builds). I think we can use the same commit from the original repo since there's a PR open for it (rjancewicz/python-kadmin#59). At least if that goes away, we'd probably need to find a more permanent replacement anyways.
There was a problem hiding this comment.
Actually, that doesn't seem to work:
Collecting git+https://github.com/rjancewicz/python-kadmin.git@7b89b1880ad09b753c8366dad114b79674d00597
Cloning https://github.com/rjancewicz/python-kadmin.git (to revision 7b89b1880ad09b753c8366dad114b79674d00597) to /tmp/pip-req-build-lsuj1890
Running command git clone -q https://github.com/rjancewicz/python-kadmin.git /tmp/pip-req-build-lsuj1890
Running command git checkout -q 7b89b1880ad09b753c8366dad114b79674d00597
fatal: reference is not a tree: 7b89b1880ad09b753c8366dad114b79674d00597
ERROR: Command errored out with exit status 128: git checkout -q 7b89b1880ad09b753c8366dad114b79674d00597 Check the logs for full command output.
There was a problem hiding this comment.
we won't be able to rerun old Travis builds
As it is, python-kadmin is not used in Travis because a KDC would be required.
In fact, it's only used in 1 place (for cleanup):
isilon_hadoop_tools/tests/conftest.py
Lines 354 to 355 in 29d9936
I'm gonna leave it for now, but I've asked the publisher of kadmin if they will publish the commit we're using. Let's keep an eye on it.
This also configures Travis for automatic deployment to PyPI when tags are pushed (the stylistic changes to
.travis.ymlwere done bytravis).