Skip to content

Fix links and Travis#73

Merged
tucked merged 6 commits intoIsilon:masterfrom
tucked:fixup
Oct 17, 2019
Merged

Fix links and Travis#73
tucked merged 6 commits intoIsilon:masterfrom
tucked:fixup

Conversation

@tucked
Copy link
Member

@tucked tucked commented Oct 16, 2019

This also configures Travis for automatic deployment to PyPI when tags are pushed (the stylistic changes to .travis.yml were done by travis).

@tucked tucked added the patch This change requires a Patch version bump. label Oct 16, 2019
@tucked tucked added this to the 4.0.1 milestone Oct 16, 2019
pytest-cov ~= 2.6.1
pytest-randomly ~= 1.2.3
python-kadmin ~= 0.1.2
git+https://github.com/twAlexM/python-kadmin.git@7b89b1880ad09b753c8366dad114b79674d00597
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should just fork this project?

Copy link
Member Author

@tucked tucked Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya... This definitely feels like a hack. I'm not too worried about it since it's test code, but if that fork ever goes away, it will break anything that ever depended on it (e.g. we won't be able to rerun old Travis builds). I think we can use the same commit from the original repo since there's a PR open for it (rjancewicz/python-kadmin#59). At least if that goes away, we'd probably need to find a more permanent replacement anyways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that doesn't seem to work:

Collecting git+https://github.com/rjancewicz/python-kadmin.git@7b89b1880ad09b753c8366dad114b79674d00597
  Cloning https://github.com/rjancewicz/python-kadmin.git (to revision 7b89b1880ad09b753c8366dad114b79674d00597) to /tmp/pip-req-build-lsuj1890
  Running command git clone -q https://github.com/rjancewicz/python-kadmin.git /tmp/pip-req-build-lsuj1890
  Running command git checkout -q 7b89b1880ad09b753c8366dad114b79674d00597
  fatal: reference is not a tree: 7b89b1880ad09b753c8366dad114b79674d00597
ERROR: Command errored out with exit status 128: git checkout -q 7b89b1880ad09b753c8366dad114b79674d00597 Check the logs for full command output.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we won't be able to rerun old Travis builds

As it is, python-kadmin is not used in Travis because a KDC would be required.
In fact, it's only used in 1 place (for cleanup):

# Delete the principal.
kadmin.init_with_password(admin_principal, admin_password).delete_principal(principal)

I'm gonna leave it for now, but I've asked the publisher of kadmin if they will publish the commit we're using. Let's keep an eye on it.

Copy link
Collaborator

@sankethsi sankethsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tucked tucked merged commit 99915f6 into Isilon:master Oct 17, 2019
@tucked tucked deleted the fixup branch October 17, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch This change requires a Patch version bump.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants