Add identities and directories for cdp#88
Conversation
|
Travis failed with error: "ERROR: More than one .egg-info directory found in /tmp/pip-pip-egg-info-o1xw8f4u". |
|
Test Done: Create dirs: |
tucked
left a comment
There was a problem hiding this comment.
Looks like the CLI plumbing (e.g. --dist cdp) is missing? I thought you might add it later, but I don't think the commands you tested with would work without it. 🤔
|
We'll also need to update the tests to exercise the new code: isilon_hadoop_tools/tests/conftest.py Line 590 in 238bf71 isilon_hadoop_tools/tests/conftest.py Lines 604 to 607 in 238bf71 isilon_hadoop_tools/tests/conftest.py Lines 615 to 618 in 238bf71 isilon_hadoop_tools/tests/test_identities.py Lines 7 to 13 in 238bf71 |
|
Closing and reopening to kick Travis... |
|
I missed to commit one file... |
1fb5f83 to
b969cb3
Compare
|
Test result: |
tucked
left a comment
There was a problem hiding this comment.
Looks great! I've kicked off a full test run and will post the results Monday 😊
|
Test result after fix: |
tucked
left a comment
There was a problem hiding this comment.
Passing run against 8e3ee11: https://gist.github.com/tucked/ae2e3f11117cb748bca1060fa67cf6fb
No description provided.