Skip to content

Add identities and directories for cdp#88

Merged
shirleylxie merged 2 commits intoIsilon:masterfrom
shirleylxie:BR_CDP
Apr 8, 2021
Merged

Add identities and directories for cdp#88
shirleylxie merged 2 commits intoIsilon:masterfrom
shirleylxie:BR_CDP

Conversation

@shirleylxie
Copy link
Copy Markdown
Collaborator

No description provided.

@shirleylxie
Copy link
Copy Markdown
Collaborator Author

Travis failed with error: "ERROR: More than one .egg-info directory found in /tmp/pip-pip-egg-info-o1xw8f4u".
It should be fixed when #87 is merged.

@shirleylxie
Copy link
Copy Markdown
Collaborator Author

Test Done:
Create users:
root@remotedev-sxie-rdu:/git/isilon_hadoop_tools/venv/bin# ./isilon_create_users --dist cdp --onefs-password a --zone System --no-verify 10.205.230.227
http://paste.west.isilon.com/247276

Create dirs:
root@remotedev-sxie-rdu:/git/isilon_hadoop_tools/venv/bin# ./isilon_create_directories --dist cdp --onefs-password a --zone System --no-verify 10.205.230.227
http://paste.west.isilon.com/247278

@shirleylxie shirleylxie self-assigned this Apr 1, 2021
@shirleylxie shirleylxie added this to the 4.0.4 milestone Apr 1, 2021
@shirleylxie shirleylxie added the minor This change requires a Minor version bump. label Apr 1, 2021
Copy link
Copy Markdown
Member

@tucked tucked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CLI plumbing (e.g. --dist cdp) is missing? I thought you might add it later, but I don't think the commands you tested with would work without it. 🤔

Comment thread src/isilon_hadoop_tools/directories.py Outdated
Comment thread src/isilon_hadoop_tools/identities.py Outdated
Comment thread src/isilon_hadoop_tools/identities.py
@tucked
Copy link
Copy Markdown
Member

tucked commented Apr 1, 2021

We'll also need to update the tests to exercise the new code:

@pytest.fixture(params=['cdh', 'hdp'])

{
'cdh': identities.cdh_identities,
'hdp': identities.hdp_identities,
}[request.param](onefs_client.zone),

{
'cdh': directories.cdh_directories,
'hdp': directories.hdp_directories,
}[request.param]()

@pytest.mark.parametrize('dist', ['cdh', 'hdp'])

@pytest.mark.parametrize(
'identities',
[
isilon_hadoop_tools.identities.cdh_identities,
isilon_hadoop_tools.identities.hdp_identities,
],
)

@tucked
Copy link
Copy Markdown
Member

tucked commented Apr 2, 2021

Closing and reopening to kick Travis...

@tucked tucked closed this Apr 2, 2021
@tucked tucked reopened this Apr 2, 2021
@shirleylxie
Copy link
Copy Markdown
Collaborator Author

I missed to commit one file...

@shirleylxie shirleylxie force-pushed the BR_CDP branch 2 times, most recently from 1fb5f83 to b969cb3 Compare April 2, 2021 03:27
@shirleylxie
Copy link
Copy Markdown
Collaborator Author

Test result:
root@remotedev-sxie-rdu:/git/isilon_hadoop_tools# tox -e py36 -- --address 10.205.229.176 --password a
http://paste.west.isilon.com/247463

Copy link
Copy Markdown
Member

@tucked tucked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've kicked off a full test run and will post the results Monday 😊

Comment thread src/isilon_hadoop_tools/_scripts.py Outdated
Comment thread src/isilon_hadoop_tools/identities.py Outdated
Comment thread src/isilon_hadoop_tools/directories.py Outdated
@shirleylxie
Copy link
Copy Markdown
Collaborator Author

Copy link
Copy Markdown
Member

@tucked tucked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shirleylxie shirleylxie merged commit c6e9c68 into Isilon:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor This change requires a Minor version bump.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants