-
Notifications
You must be signed in to change notification settings - Fork 2
chore: update to Expo 55, RN 0.83.2, and Node.js version 20.19.4; bump version to 1.1.0 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v20.19.0 | ||
| v20.19.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ the native code is generated through `expo prebuild`. | |
| - [π Quick Start](#-quick-start) | ||
| - [π§ Configuration](#-configuration) | ||
| - [Plugin Options](#plugin-options) | ||
| - [Disabling New Architecture](#disabling-new-architecture) | ||
| - [New Architecture](#new-architecture) | ||
| - [Adding push capabilities](#adding-push-capabilities) | ||
| - [iOS](#ios) | ||
| - [Android](#android) | ||
|
|
@@ -129,15 +129,14 @@ Add the plugin to your `app.json` or `app.config.js`: | |
| | `enableTimeSensitivePush` | boolean | `true` | Whether to enable time-sensitive push notifications (iOS only) | | ||
| | `requestPermissionsForPushNotifications` | boolean | `false` | Whether to request permissions for push notifications (iOS only) | | ||
|
|
||
| ### Disabling New Architecture | ||
| ### New Architecture | ||
|
|
||
| `@iterable/react-native-sdk` is _NOT_ compatible with Reacts New Architecture, | ||
| so this needs to be disabled in your `app.json`: | ||
| Expo SDK 55 requires React Native's [New Architecture](https://reactnative.dev/architecture/landing-page). Ensure `newArchEnabled` is set to `true` in your `app.json`: | ||
|
|
||
| ```json | ||
| { | ||
| "expo": { | ||
|
Comment on lines
+134
to
138
|
||
| "newArchEnabled": false | ||
| "newArchEnabled": true | ||
| } | ||
| } | ||
| ``` | ||
|
|
@@ -374,14 +373,9 @@ If you encounter the error "Signing for 'IterableExpoRichPush' requires a develo | |
|
|
||
| ## β Requirements and Limitations | ||
|
|
||
| - From v2.0.2,`@iterable/react-native-sdk` supports React Native's New | ||
| Architecture](https://reactnative.dev/architecture/landing-page) through the | ||
| Interop Layer. We are in the process of updating the SDK to fully support the | ||
| New Architecture, and suggest using the legacy architecture in the meantime. | ||
| *TLDR;* Use the New Architecture at your own risk -- you may encounter | ||
| significant issues. | ||
| - See [Disabling New Architecture](#disabling-new-architecture) for | ||
| instructions on how to disable new architecture in your app. | ||
| - From v2.0.2, `@iterable/react-native-sdk` supports React Native's New | ||
| Architecture. Expo SDK 55 requires the New | ||
| Architecture; see [New Architecture](#new-architecture) for configuration. | ||
|
Comment on lines
+376
to
+378
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 |
||
| - Your expo app needs to be run as a [development | ||
| build](https://docs.expo.dev/develop/development-builds/introduction/) instead | ||
| of through Expo Go. Both | ||
|
|
@@ -391,8 +385,8 @@ If you encounter the error "Signing for 'IterableExpoRichPush' requires a develo | |
| - `@iterable/iterable-expo-plugin` is intended for managed workflows, and will | ||
| overwrite the files in your `ios` and `android` directories. Any manual | ||
| changes to those directories will be overwritten on the next build. | ||
| - This plugin has been tested on Expo version 52+. While it may work on | ||
| previous versions, they are not supported. | ||
| - This plugin has been tested on Expo SDK 55. While it may work on previous | ||
| versions, they are not supported. | ||
|
|
||
| ## π Features | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lposen does this Copilot comment sounds reasonable to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No -- see above