fix: repair brief worker scaffold parser - #5
Open
ItsFlow wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Urgently repair the worker-launch blocker in bin/fm-brief.sh introduced by ec09871. Make the smallest syntax-only correction without redesigning the brief generator or changing unrelated behavior; identify the malformed shell construct; preserve worktree isolation, status reporting, decision escalation, and each delivery-specific completion contract. Require bash -n, repository-pinned ShellCheck/lint, existing brief-generator tests, isolated no-mistakes/direct-PR/local-only/scout scaffolding, and a strengthened parser regression test. Commit, push through the complete no-mistakes pipeline, open a PR, and reach green CI without merging.
What Changed
bin/fm-brief.shparsing while preserving the authority-check meaning.Risk Assessment
✅ Low: The change is tightly scoped to removing the apostrophe that broke parsing in the
DOD=$(cat <<EOF ... EOF)block and updating targeted regression assertions, with no behavior drift found.Testing
bash -nand the selected brief-generator/authority tests passed, generated brief artifacts demonstrate the user-facing scaffold contracts across no-mistakes/direct-PR/local-only/scout modes, and the worktree stayed clean; I did not run local lint/static analysis per the validation rule, but PR CI records the lint job passing while the required no-mistakes PR gate remains failed.Evidence: Selected parser and behavior test transcript
Evidence: Selected test timing artifact
Evidence: Generated brief end-to-end transcript
Evidence: Generated no-mistakes brief
Evidence: Generated direct-PR brief
Evidence: Generated local-only brief
Evidence: Generated scout brief
Evidence: PR and CI status transcript
PR checks show 9 passed, 1 failed; the failed check isPR must be raised via no-mistakes.Evidence: Require no-mistakes failure log
Source: Require no-mistakes failure log (local file:
/var/folders/tc/llfmckm54ls5tzxm08q758lm0000gn/T/no-mistakes-evidence/01KYR10AZV6VM6VR1EEP3A72SJ/require-no-mistakes-failure-log.txt)Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
gh-axi pr checks 5reports9 passed, 1 failed, 10 total, withPR must be raised via no-mistakesfailing. The failing run says the PR body lacks the no-mistakes signature and reportsThis PR was not raised through no-mistakes, so the author intent requirement to push through the complete no-mistakes pipeline and reach green CI is not satisfied.bash -n bin/fm-brief.shbin/fm-test-run.sh --json /var/folders/tc/llfmckm54ls5tzxm08q758lm0000gn/T/no-mistakes-evidence/01KYR10AZV6VM6VR1EEP3A72SJ/fm-brief-selected-tests.json tests/fm-brief.test.sh tests/fm-ask-user-authority.test.shGenerated end-user briefs withFM_HOME=/var/folders/tc/llfmckm54ls5tzxm08q758lm0000gn/T/no-mistakes-evidence/01KYR10AZV6VM6VR1EEP3A72SJ/generated-brief-home bin/fm-brief.shfor no-mistakes, direct-PR, local-only, and scout paths, then checked isolation/status/decision/DOD wording and apostrophe regressions./opt/homebrew/bin/gh-axi pr view 5/opt/homebrew/bin/gh-axi pr checks 5/opt/homebrew/bin/gh-axi run view 30489124908/opt/homebrew/bin/gh-axi run view 30489124720 --loggit status --short✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.