feat(selfhost): allow per-repo AI CLI timeout overrides in review.ai_model (#8364)#8435
Closed
andriypolanski wants to merge 4 commits into
Closed
Conversation
…model (JSONbored#8364) Mirror the existing model/effort config-as-code path for the four CLI timeout knobs so a shared self-host instance is not stuck on one global env-var budget per repo. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8435 +/- ##
===========================================
+ Coverage 59.66% 93.63% +33.97%
===========================================
Files 791 694 -97
Lines 79319 56639 -22680
Branches 23952 20103 -3849
===========================================
+ Hits 47325 53034 +5709
+ Misses 28250 2652 -25598
+ Partials 3744 953 -2791
Flags with carried forward coverage won't be shown. Click here to find out more.
|
andriypolanski
force-pushed
the
feat/8364-ai-cli-timeout-manifest-overrides
branch
from
July 24, 2026 13:45
a1673f2 to
8307c67
Compare
Contributor
|
This repository reviews pull requests one-shot: the PR must be correct as originally opened. Pushing an additional commit closes it automatically instead of restarting review — open a fresh pull request with every fix included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.loopover.ymlfields underreview.ai_model:claude_timeout_ms,codex_timeout_ms,claude_first_output_timeout_ms,codex_first_output_timeout_ms(same section asclaude_model/claude_effort).AiRunOptions/runLoopOverAiReview/ the CLI providers;resolve*TimeoutMsprefer a positive per-repo override, else keep today’s env-var/effort resolution.ai-review-input:v6so a timeout-only manifest change invalidates cached reviews.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typecheckselfhost-aitimeout suites,focus-manifestreview.ai_model,ai-reviewoverride forwarding,ai-review-cache-inputnpm run test:coveragenpm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
config-lint.tsonly validates top-level manifest keys (reviewis already recognized). Nestedreview.ai_model.*fields are recognized the same wayclaude_modelalready is — by parsing infocus-manifest.ts, not a nested allowlist in config-lint. Untouched CI surfaces left to CI.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.