test(engine): make self-review-adapter coverage visible to Codecov

[cleanjunc]

Closes #8348

Summary

• packages/loopover-engine/src/miner/self-review-adapter.ts (maintainer: self-review adapter wiring iterate-loop diffs through predicted-gate + slop scoring #2334) turns an attempt's live worktree diff into the same inputs buildPredictedGateVerdict and an injected slop-assessment function expect, so the miner's self-review pass is byte-identical in shape to the live maintainer gate. It exports buildSelfReviewPredictedGateInput, buildSelfReviewChangedPaths, buildSelfReviewSlopInput, runSelfReview, and SELF_REVIEW_PASSING_CONCLUSION. It is fully exercised by the engine package's own node --test suite (packages/loopover-engine/test/self-review-adapter.test.ts), but that runner is not part of the root vitest run Codecov reads codecov/patch from, so it reports as ~0% covered despite being genuinely tested. Same blind spot as fix(ci): review-enrichment's real node:test coverage is invisible to Codecov (83 of 83 files effectively unmeasured) #6250.
• Adds a root-level vitest twin, test/unit/self-review-adapter.test.ts, importing the adapter functions via the engine barrel (../../packages/loopover-engine/src/index) and mirroring every scenario the package suite covers — following the sibling pattern in test/unit/calibration-dashboard.test.ts.
• Adds a short note to the engine README documenting the root mirror. This README touch is deliberate and load-bearing — see "Why the README change" below.
• No change to any file under packages/loopover-engine/src/** or packages/loopover-engine/test/**. It uses buildPredictedGateVerdict + parseFocusManifest and an injected runSlopAssessment fake exactly as the package suite does — the real src/signals/slop.ts is never imported.

Covered, per the issue's requirements: buildSelfReviewPredictedGateInput (each of body/labels/linkedIssues/authorAssociation present and omitted — both arms of every conditional spread), buildSelfReviewChangedPaths (path mapping in order + the empty-array case), buildSelfReviewSlopInput (the ?? null description fallback for present-body vs undefined→null, and hasLinkedIssue from ?.length ?? 0 > 0 across undefined / empty / non-empty linkedIssues), and runSelfReview (changedPaths always threaded through; each optional SelfReviewContext field present and omitted; the injected runSlopAssessment called with the built input and its result returned verbatim; passesPredictedGate true only for a "success" conclusion and false for a real blocked verdict). Locally this brings the source to 100% line + branch under vitest.

Why the README change (please read before grading scope)

A pure test/**-only diff that touches no packages/loopover-engine/** path is classified by CI as a scoped, coverage-artifact-free run: each shard runs vitest --changed=origin/main --coverage.all=false, produces an empty coverage/lcov.info (no changed src/**), and skips uploading its coverage blob. With zero blobs, validate-tests-merge then fails with ENOENT … all-blob-reports, failing validate. Touching an engine-package path (documenting the mirror in the README) flips CI onto the full-coverage run, whose shards upload real blobs so the merge job passes — the same doc touch the merged twins for #8349/#8344/#8343/#8345 used. It adds zero src/** production lines, so codecov/patch still has nothing on this diff to grade.

Scope

• The PR title follows type(scope): short summary Conventional Commit format.
• Focused: a single new test file plus a directly-related, CI-load-bearing README note; no unrelated backend/UI/MCP/dep/deploy changes.
• Follows CONTRIBUTING.md; does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves — Closes #8348.

Validation

• git diff --check — clean.
• npm run actionlint — N/A: no workflow / composite-action changes.
• npm run typecheck — green (after building @loopover/engine, as the root test:ci sequence does before typecheck).
• npm run test:coverage locally — the new file passes (15 tests) and reports 100% line + branch coverage of self-review-adapter.ts.
• npm run test:workers — N/A: no worker code changed.
• npm run build:mcp / npm run test:mcp-pack — N/A: no MCP changes.
• npm run ui:openapi:check / npm run ui:lint / npm run ui:typecheck / npm run ui:build — N/A: no UI, API, or OpenAPI surface changed.
• npm audit --audit-level=moderate — not run locally (sandbox audit endpoint returns a lockfile 400); no dependency changes, so it cannot affect the audit. CI runs it against a clean install.
• New or changed behavior has unit tests — this PR is the added test coverage; no production behavior changed.

If any required check was skipped, explain why:

• All skipped checks are N/A for a PR that adds one root-level vitest file plus a docs note, with no production, UI, MCP, API, workflow, or dependency changes.

Safety

• No secrets, wallet details, hotkeys, coldkeys, PATs, private keys, trust scores, private rankings, or maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and implies no compensation or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests — N/A: none changed.
• API/OpenAPI/MCP behavior is updated and tested where needed — N/A: none changed.
• UI changes use live API data / real empty/error/loading states — N/A: no UI changes.
• Public docs/changelogs updated where needed; CHANGELOG.md not edited (not a release-prep PR).

Notes

• The test imports the adapter functions and fixture types from the engine barrel, not a relative path into the source file, matching every existing sibling root-level engine test.
• No behavior of self-review-adapter.ts was changed, and the package's own node --test suite was left untouched, as the issue requires.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.50%. Comparing base (7f5550b) to head (51dcd3b).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #8466       +/-   ##
===========================================
+ Coverage   80.86%   92.50%   +11.64%     
===========================================
  Files         791      791               
  Lines       79320    79333       +13     
  Branches    23954    23961        +7     
===========================================
+ Hits        64142    73389     +9247     
+ Misses      12156     4807     -7349     
+ Partials     3022     1137     -1885     

Flag	Coverage Δ
shard-1	53.51% <ø> (-4.86%)	⬇️
shard-2	50.59% <ø> (-0.52%)	⬇️
shard-3	58.63% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 241 files with indirect coverage changes

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-24 14:59:33 UTC}

2 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This is a pure test-addition PR: it adds a root-level vitest twin of the existing package-local node:test suite for self-review-adapter.ts, importing only via the public engine barrel with an injected slop-assessment fake, plus a short README note documenting the mirror. The pattern matches prior accepted PRs of the same shape (#8345, #8349, #8343) referenced in the README, no source under packages/loopover-engine/src is touched, and the tests exercise real conditional-spread/nullish-coalescing branches (both arms) rather than fabricated states. It closes the linked issue #8348 and CI is fully green.

Nits — 3 non-blocking

• The README.md flagged as a long-file (696 lines, threshold 400) is pre-existing bloat this PR adds 5 more lines to rather than causing — worth a follow-up to split package docs, but not this PR's problem to solve.
• test/unit/self-review-adapter.test.ts:1-12 carries an unusually long top-of-file comment block restating the whole PR rationale; consider trimming to a one-line pointer since the README now documents the pattern.
• If a future self-review-adapter change touches src/miner/self-review-adapter.ts, remember both the package node:test suite and this vitest twin need updating in lockstep — consider a lint/CI check that fails when one changes without the other, mirroring the risk called out in fix(ci): review-enrichment's real node:test coverage is invisible to Codecov (83 of 83 files effectively unmeasured) #6250.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8348
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 60 registered-repo PR(s), 25 merged, 37 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	cleanjunc; Gittensor profile; 60 PR(s), 37 issue(s).
Improvement	ℹ️ Insufficient signal	risk: clean · value: insufficient-signal · LLM: minor

Linked issue satisfaction

Addressed
The PR adds the required root-level vitest file test/unit/self-review-adapter.test.ts importing the adapter functions via the engine barrel and mirroring the scenarios called out in the issue (optional-field spreads, changedPaths mapping, slop input derivation, and runSelfReview's optional context fields and conclusion handling), plus a documentation note, without touching the restricted source/te

Review context

• Author: cleanjunc
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 60 PR(s), 37 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Triage stale or unlinked PRs.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.