fix(miner): delegate three resolve*DbPath helpers to resolveLocalStoreDbPath (#8336)#8496
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (99.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8496 +/- ##
==========================================
- Coverage 92.53% 88.25% -4.29%
==========================================
Files 793 100 -693
Lines 79483 23049 -56434
Branches 24017 3980 -20037
==========================================
- Hits 73547 20341 -53206
+ Misses 4799 2530 -2269
+ Partials 1137 178 -959
Flags with carried forward coverage won't be shown. Click here to find out more.
|
df15f70 to
166a2fe
Compare
|
Hi @JSONbored, you updated bot, why doesn’t the bot detect two-shot submissions? |
Because it's a one-shot bot, not a two-shot bot, and there's currently a large backlog/lag from all the submissions it's working through. Have some patience. |
|
This repository reviews pull requests one-shot: the PR must be correct as originally opened. Pushing an additional commit closes it automatically instead of restarting review — open a fresh pull request with every fix included. |
Summary
resolveOrbExportDbPath,resolveDenyHookSynthesisDbPath, andresolveLaptopStateDbPathtoresolveLocalStoreDbPath(same one-line pattern asresolvePredictionLedgerDbPath).LOOPOVER_MINER_LAPTOP_STATE_DBas the laptop store's explicit override (paths unchanged when unset). Leave privateresolveMinerStateDirinlaptop-init.tsfor non-SQLite callers.packages/loopover-miner/docs/env-reference.mdandapps/loopover-ui/src/lib/ams-env-reference.tsvianpm run miner:env-reference(""to(none)for the two pure refactors; new laptop row).Closes #8336
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
packages/loopover-miner/**is not Codecov-gated). Locally verified: typecheck, miner env-reference check, targeted vitest for orb-export / deny-hook-synthesis / laptop-init (path + override + parity cases), test:workers, engine/live-gate/driver parity, ui:typecheck, docs/branding drift checks, and npm audit. Fullnpm run test:cihits a known Windows path double-prefix in minercheck-syntax.mjsand Windowsnpm packfailures unrelated to this diff; those steps run on Linux CI.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — generated AMS env-reference sync only; no visible UI change.
Notes
LOOPOVER_MINER_LAPTOP_STATE_DB; default path resolution unchanged when unset.