Skip to content

test(scoring): cover model.ts's unpinned-fallback and language-fetch-failed warning branches #8499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
galuis116 wants to merge 1 commit into from
Closed

test(scoring): cover model.ts's unpinned-fallback and language-fetch-failed warning branches #8499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test/unit/scoring.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,26 @@ NOVELTY_BONUS_SCALAR = 3
expect(refreshed.payload.upstreamSourceSha).toBeUndefined();
expect(refreshed.constants.MERGED_PR_BASE_SCORE).toBe(25);
expect(refreshed.sourceKind).toBe("raw-github");
// The unpinned fall-back is surfaced as an operator-facing warning — the sole signal that
// scoring is currently running against a mutable ref rather than a pinned commit SHA.
expect(refreshed.warnings).toContainEqual(expect.stringMatching(/unpinned/i));
});

it("warns and falls back to an empty programmingLanguages map when the language-weights fetch fails after constants succeed", async () => {
const env = createTestEnv({ GITHUB_PUBLIC_TOKEN: "token" });
vi.stubGlobal("fetch", async (input: RequestInfo | URL) => {
const url = input.toString();
if (url.includes("constants.py")) return new Response(VALID_CONSTANTS_PY + "MERGED_PR_BASE_SCORE = 25\n");
if (url.includes("programming_languages.json")) return new Response("not found", { status: 404 });
return new Response("not found", { status: 404 });
});

const refreshed = await refreshScoringModelSnapshot(env);

// Constants still refresh normally — only the languages fetch degraded.
expect(refreshed.sourceKind).toBe("raw-github");
expect(refreshed.programmingLanguages).toEqual({});
expect(refreshed.warnings).toContainEqual(expect.stringMatching(/Programming language weights fetch failed/));
});

it("pins the constants fetch to the resolved upstream SHA (immutable) when it can be resolved", async () => {
Expand Down
Loading