fix(miner): route orb-export, deny-hook-synthesis, and laptop-init through openLocalStoreDb (#8319)

[milosde111]

Summary

Three local SQLite stores still hand-rolled new DatabaseSync + mkdir/chmod/busy_timeout instead of openLocalStoreDb, skipping crash-safe cleanup registration (#4826). This applies the same substitution plan-store.ts / attempt-log.ts already use.

• orb-export.ts / deny-hook-synthesis.ts / laptop-init.ts: open via openLocalStoreDb (laptop samples created before open).
• Tests: crash-safe registration assertions, and .ts-via-variable dynamic imports so CI’s pre-test miner build does not attribute coverage to built .js while Codecov grades .ts (the .js-vs-.ts mismatch that closed fix(miner): route orb-export, deny-hook-synthesis, and laptop-init through openLocalStoreDb (#8319) #8500/fix(miner): delegate orb-export/deny-hook-synthesis/laptop-init DB opening to crash-safe openLocalStoreDb #8516 at 0% patch). Same pattern as miner-replay-snapshot.test.ts (replay-snapshot.ts's normalizeCommitSha has no format validation, letting a crafted value escape the intended snapshot directory via path.join #7796).

Closes #8319

Scope

• The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
• This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
• This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
• I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

• git diff --check
• npm run actionlint
• npm run typecheck
• npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
• npm run test:workers
• npm run build:mcp
• npm run test:mcp-pack
• npm run ui:openapi:check
• npm run ui:lint
• npm run ui:typecheck
• npm run ui:build
• npm audit --audit-level=moderate
• New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

Miner-lib-only change. Reproduced the #8500/#8516 codecov failure locally (built .js beside .ts → .ts patch at 0% under static .js imports) and confirmed the .ts-via-variable import leaves the three openLocalStoreDb(...) lines hit on the .ts paths Codecov grades. Run full npm run test:ci before push.

Safety

• No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
• Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
• Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. (N/A.)
• API/OpenAPI/MCP behavior is updated and tested where needed. (N/A.)
• UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks. (N/A.)
• Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots. (N/A.)
• Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs. (N/A.)

Notes

No import cycle for laptop-init.ts → ./local-store.js. Prior PRs for this issue failed codecov/patch at 0% because tests imported the built .js; this PR instruments the .ts source Codecov grades.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.05%. Comparing base (ee4fa21) to head (88321cd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8529      +/-   ##
==========================================
- Coverage   89.58%   89.05%   -0.53%     
==========================================
  Files          97      100       +3     
  Lines       22706    23041     +335     
  Branches     3872     3980     +108     
==========================================
+ Hits        20341    20520     +179     
- Misses       2187     2335     +148     
- Partials      178      186       +8     

Flag	Coverage Δ
backend	53.43% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/loopover-miner/lib/deny-hook-synthesis.ts	96.55% <100.00%> (ø)
packages/loopover-miner/lib/laptop-init.ts	36.42% <100.00%> (ø)
packages/loopover-miner/lib/orb-export.ts	52.55% <100.00%> (ø)

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-24 18:55:26 UTC}

6 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · unknown

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR replaces hand-rolled `mkdirSync`/`DatabaseSync`/`chmodSync`/busy_timeout boilerplate in `orb-export.ts`, `deny-hook-synthesis.ts`, and `laptop-init.ts` with the shared `openLocalStoreDb` helper, matching the pattern `plan-store.ts`/`attempt-log.ts` already use, and gains crash-safe cleanup registration (`#4826`) that `laptop-init.ts` previously had none of at all. I traced `openLocalStoreDb` in `local-store.ts` and confirmed it performs the same mkdir(0o700)/chmod(0o600)/busy_timeout sequence plus `registerCleanupResource`, so behavior is preserved with the added crash-safety win; the `laptop-init.ts` `created` sampling is correctly moved before the `openLocalStoreDb` call since the helper itself creates the file. Tests add real `cleanupResourceCount()` assertions around registration/unregistration and switch to `.ts`-via-variable dynamic imports to keep Codecov attributing coverage to source instead of the built `.js`, mirroring the established `miner-replay-snapshot.test.ts` (#7796) pattern.

Nits — 3 non-blocking

• laptop-init.ts's `chmodSync(dbPath, 0o600)` now happens immediately inside `openLocalStoreDb` (before table creation/insert) rather than at the very end as before — functionally equivalent since the goal is that the file end up 0600, but worth a one-line confirmation in the PR description since it does shift the moment permissions tighten relative to writes.
• In `deny-hook-synthesis.ts` and `orb-export.ts` the `DatabaseSync` import was narrowed to `import type`, which is correct since only the type annotation on `ensureDenyRuleProposalsForgeScope`/none remains — worth double-checking no other runtime use of `DatabaseSync` was silently dropped, though the full file content shown confirms none remains.
• Nice catch documenting in a comment that `laptop-init.ts` was 'previously the one store with no busy-timeout and no crash-safety registration at all' — consider carrying that same framing into the CHANGELOG/PR body so downstream operators know the risk this closes.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8500, #8319
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (2 linked issues).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 242 registered-repo PR(s), 162 merged, 9 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	milosde111; Gittensor profile; 242 PR(s), 9 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff replaces the hand-rolled mkdirSync/DatabaseSync/chmodSync/PRAGMA sequence in orb-export.ts, deny-hook-synthesis.ts, and laptop-init.ts with openLocalStoreDb, matching the issue's exact ask, and adds crash-safe cleanup registration tests for each store as described.

Review context

• Author: milosde111
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 242 PR(s), 9 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review