fix(queue): stop paging Sentry daily for release-please PRs' expected stuck CI#8530
Merged
Merged
Conversation
… stuck CI Sentry LOOPOVER-2F: the stuck-CI repeat signal paged daily for 7 days about loopover#8273 -- the release-please PR, whose CI never settles BY DESIGN, and which self-cleared the moment it merged. Release PRs here are PAT-authored (so their CI can trigger at all), making them invisible to the bot-typed-actor skip in settings/automation-bot-skip.ts. When the stuck PR's head branch matches release-please's well-known release-please-- prefix, the once-a-day coalesced signal now logs at warn via console.warn (sink matches level per #7806) -- below the structured-log Sentry forwarder's threshold, still visible in Workers Logs. The finalize guard, audit trail, defer behavior, and the error-level page for every regular PR are untouched. Branch-name matching is safe for this: nothing security-relevant hangs off it -- a contributor naming their branch this way only quiets their own PR's Sentry ping, never the guard or any review/trust decision.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8530 +/- ##
===========================================
+ Coverage 78.66% 91.98% +13.31%
===========================================
Files 793 793
Lines 79483 79564 +81
Branches 24017 24046 +29
===========================================
+ Hits 62526 73184 +10658
+ Misses 13908 5306 -8602
+ Partials 3049 1074 -1975
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sentry LOOPOVER-2F: the stuck-CI repeat signal (
ci_stuck_review_repeat_suppressed) paged daily for 7 days about PR #8273 — the release-please PR, whose CI never settles by design, and which self-cleared the moment it merged. Release PRs here are PAT-authored (so their CI can trigger at all), which makes them invisible to the bot-typed-actor skip insettings/automation-bot-skip.ts.Fix: when the stuck PR's head branch matches release-please's well-known
release-please--prefix, the once-a-day coalesced signal logs atwarninstead oferror— below the structured-log Sentry forwarder's threshold, still visible in Workers Logs. Everything else is untouched: the finalize guard, the audit trail, the defer behavior, and the error-level page for every regular PR. Branch-name matching is safe for this because nothing security-relevant hangs off it — a contributor naming their branch this way only quiets their own PR's Sentry ping, never the guard or any review/trust decision.Validation
release-please--branches--mainhead (assertslevel: "warn") and afeature/stuck-cihead (assertslevel: "error"), plus identical guard/defer counts for both.npx vitest run test/unit/queue.test.ts— 181 passed.npm run typecheckclean;npm run test:coverage(unsharded) green.