feat(miner): capture bounded candidate context in eligibility-exclusion metadata#8555
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (93.93%) is below the target coverage (99.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8555 +/- ##
==========================================
- Coverage 89.58% 88.77% -0.82%
==========================================
Files 97 98 +1
Lines 22706 22955 +249
Branches 3872 3960 +88
==========================================
+ Hits 20341 20378 +37
- Misses 2187 2399 +212
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-24 20:35:27 UTC
Review summary Nits — 1 non-blocking
CI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (CI is failing (codecov/patch)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
|
Reopening: this PR was auto-closed on a phantom codecov/patch (0%/99%) failure — a CI bug (in-place package build output shadowing the .ts sources during the coverage run), not a problem with this PR. Fixed in #8564; updating the branch now to get a fresh run under the fixed workflow. |
JSONbored
left a comment
There was a problem hiding this comment.
Issue has already been solved, closing.
|
Closing note: while the CI incident above was being fixed, your own resubmission of this exact change (#8561) was reviewed and merged, and issue #8544 is closed by it — this earlier version is superseded by your landed PR (that's also why the branch conflicts with main now). Nothing wrong with this PR's content; the work shipped. |
…on metadata
Summary
recordEligibilityExclusionSignalsindiscover-cli.tsso each real-run eligibility exclusion records boundedmetadataon the fired event:labels,assignees, andowner(when present on the excluded candidate).truncated: trueonly when a cap actually clamps; absent fields omitted (nonull, no empty-array placeholders).contribution-profile-filter.tsuntouched; dry-run still records nothing; best-effort discipline preserved (metadata capture cannot abort discovery).Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlintnpm run typechecknpm run build:minernpx vitest run test/unit/miner-discover-cli-eligibility-metadata.test.ts test/unit/miner-discover-cli.test.ts -t "eligibility-exclusion signal tracking|buildEligibilityExclusionMetadata"— 13 passednpm run build:miner && npx vitest run test/unit/miner-discover-cli-eligibility-metadata.test.ts test/unit/miner-discover-cli.test.ts -t "eligibility-exclusion signal tracking|buildEligibilityExclusionMetadata" --coverage.all=false --coverage && npx diff-cover coverage/lcov.info --compare-branch=origin/mainnpm run test:coverage(full unsharded gate)npm run test:cinpm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
packages/loopover-miner/lib/discover-cli.ts). New unit tests import.tsvia variable specifier (miner-discover-cli-eligibility-metadata.test.ts) socodecov/patchgrades changed lines under--coverage.all=false. Fulltest:cileft to CI.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.