fix: compatibility for React strict mode#26
Closed
jlarmstrongiv wants to merge 2 commits intoJackHowa:mainfrom
Closed
fix: compatibility for React strict mode#26jlarmstrongiv wants to merge 2 commits intoJackHowa:mainfrom
jlarmstrongiv wants to merge 2 commits intoJackHowa:mainfrom
Conversation
Owner
|
hi @jlarmstrongiv ! I want to make sure this will still work as expected for the package users; are there test steps that you're working off of? happy to test this out locally |
JackHowa
requested changes
Sep 28, 2021
Owner
JackHowa
left a comment
There was a problem hiding this comment.
Looks like some of the tests fail. Let me know if you have time for this? I want to make sure this change is safe moving forward to react 17
lib/__tests__/index.test.js
with children
✓ renders children (30 ms)
with no children
✓ renders null (4 ms)
ActionCableConsumer
wrapped with ForwardRef
✓ renders the ForwardRef (6 ms)
✕ renders the consumer (126 ms)
✕ renders the controller (11 ms)
ActionCableController
with cable passed to provider
✕ passes cable to the controller as a prop (5 ms)
with children
✕ renders children (7 ms)
without children
✕ renders null (7 ms)
This was referenced Sep 29, 2021
Owner
|
Didn't hear back on this; may be breaking change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See cpunion#39