Conversation
- Remove deployment script and user-assigned managed identity - Support client secret auth (AZURE_CLIENT_ID, AZURE_CLIENT_SECRET, AZURE_TENANT_ID) - Simplify templates: just storage account, app service plan, function app - User uploads code manually via Deployment Center - Both ADX and Log Analytics backends updated https://claude.ai/code/session_01BhLDKYffqvD2B2V71qLeV2
- BUGFIX: Function files now use get_ingestion_client() instead of hardcoded ADXClient, enabling Log Analytics backend to work - Remove unused imports from shared/__init__.py (Protocol, KustoClient) - Remove unused Config fields (dry_run, output_path) - Move StringIO import to top level - Delete obsolete Grant-AzureRoles.ps1 (no longer using managed identity RBAC) - Update Grant-GraphPermissions.ps1 to work with both app registrations and managed identities, with backwards-compatible parameter aliases https://claude.ai/code/session_01BhLDKYffqvD2B2V71qLeV2
- Simplify Bicep templates: credentials added manually after deployment - Remove incomplete CosmosDB template (dead code) - Use DRY pattern in Log Analytics template (table schemas reused) - Update .env.example with correct variable names - Clean up .bicepparam files Deployment flow is now: 1. Deploy Bicep template (just baseName required) 2. Add credentials in portal: AZURE_TENANT_ID, AZURE_CLIENT_ID, AZURE_CLIENT_SECRET 3. Grant Graph permissions + ADX Ingestor role (or DCR role for Log Analytics) 4. Upload code via Deployment Center https://claude.ai/code/session_01BhLDKYffqvD2B2V71qLeV2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01BhLDKYffqvD2B2V71qLeV2