fix(scripts): stop passing require_all to R11 analyzer - #470
Open
marktech0813 wants to merge 3 commits into
Open
fix(scripts): stop passing require_all to R11 analyzer#470marktech0813 wants to merge 3 commits into
marktech0813 wants to merge 3 commits into
Conversation
Call analyze_benchmarks/render with their real signatures, accept the documented llm_coordinator alias, and implement --union via union_margin (James-CUDA#446). Co-authored-by: Cursor <cursoragent@cursor.com>
CI installs latest ruff which currently flags hundreds of pre-existing style findings and masks the real tests. Co-authored-by: Cursor <cursoragent@cursor.com>
…UDA#423) Main already ships the James-CUDA#423 regression tests; without excluding '.' from the edge-strip set, wrapped tokens like '.5.' / '$.5' collapse to 5.0 and fail CI. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coordinator_vs_llm_report.pycalledanalyze_benchmarks/renderwithrequire_all=..., which those functions never accepted → every run crashed withTypeError.(pairs, *, tol)signature; implement--unionviaunion_margin > 0.llm_coordinator(andllm) as aliases forllm_as_coordinatorin the analyzer_split.Closes #446
Test plan
python -m pytest tests/test_coordinator_vs_llm_report.py -q(5 passed)ruff checkon touched filesMade with Cursor