Feat/auto install prompt completion#27
Merged
Merged
Conversation
- `config set-prompt on` now auto-injects shell integration into the detected rc file (bash, zsh, fish) so users no longer need to edit .bashrc/.zshrc/config.fish manually. Uses a `# ghem prompt indicator` marker to stay idempotent; `off` continues to toggle the runtime flag. - Add `config set-completion <on|off>` mirroring set-prompt, reusing installCompletion() and a new uninstallCompletion() that strips the marker block from the rc file. - Extend i18n (en, ko) with install/uninstall messages and register the new subcommand in bash/zsh completion scripts.
|
Caution Review failedPull request was closed or merged during review WalkthroughVersion bumped to 1.2.13 with new shell integration features: Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
config set-completion on/offcommand to enable or disable shell completionChores