Added json import and export#9
Open
David-Prelinger wants to merge 3 commits intoJankoLancer:masterfrom
Open
Conversation
|
I tried to use your fork with the json way and it is really faster, but it produces a 2.5x bigger .json file than an .csv file. So the best here could be given the option to export/import as json, but also make an better implementation for that GeocodeData constructor, it should use a stream to read the csv and use an isolate to compute that amount of info without freezing the UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, we needed a way to quicker initialize our app. Loading a huge huge csv took to long for every app start. So I added functionality here, so you can once init the kdtree from csv and then in the future always import the indexed json. This proved to be much much faster like 10x than before. I also removed the test data, because it bloated our app size.
Would be great if you merge this, otherwise we will just use it as our own fork. Thanks!