Conversation
idk, everything uploaded? lol
fixed indentation and (old data) for bunch_o_screenshots
| } | ||
|
|
||
| // When updating, apply meta data changes to plugins.json entry! | ||
| BBPlugin.register("plugin", { |
There was a problem hiding this comment.
Please ensure ID consistency. The plugin directory currently has a different ID compared to the one specified in plugins.json, and the name here plus the file name is just "plugin" when it should be the proper plugin ID.
| Settings.openDialog(); | ||
| Settings.dialog.close(0); | ||
| BosSettings["BoSoutputDirectory"].set(fallbackDirectory); | ||
| Blockbench.showMessageBox({ |
There was a problem hiding this comment.
This error message seems to pop up when first installing the plugin.
| const projectName = Project | ||
| ? Project.name.replace(/\.geo$/, "") | ||
| : "screenshot"; | ||
| savePath = `${currentSettings.outputDirectory}\\${projectName}.png`; |
There was a problem hiding this comment.
The backslash for file paths is only going to work on Windows. Please use the character that works for the respective system. You can use the NodeJS path module (PathModule) to make this easier and more reliable.
| type: "click", | ||
| click: function () { | ||
| let dialog = new Dialog({ | ||
| title: "WIP", |
There was a problem hiding this comment.
This does not seem to do anything, you should comment it out.
| if (BosSettings == null) { | ||
| doLog("create settings"); | ||
| BosSettings = { | ||
| BoSdevMode: new Setting("BoSdevMode", { |
There was a problem hiding this comment.
You can just spell out names with spaces in between, no need to cram it all into one word.
2 participants
Fixed previous issues and conflicting change, hope this works now :)