Skip to content

Add PoseKey Plugin#847

Open
OnirisHub wants to merge 4 commits intoJannisX11:masterfrom
OnirisHub:master
Open

Add PoseKey Plugin#847
OnirisHub wants to merge 4 commits intoJannisX11:masterfrom
OnirisHub:master

Conversation

@OnirisHub
Copy link

I added a PoseKey plugin to Blockbench, which allows adding a key to the entire animated group (customize toolbar > PoseKey).

Copy link
Owner

@JannisX11 JannisX11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few notes.


let final_targets = getAllDescendants(selection_base);

Undo.initEdit({purpose: 'PoseKey Single'});
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo currently does not work. "purpose" is not a valid property. Instead, you need to init the edit with the empty list of keyframes, and then finish it with all the newly created keyframes.

title: 'PoseKey',
author: 'FroXaL',
icon: 'key',
description: 'Poses a unique keyframe on the entire group.',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rephrase the description so that it is a bit clearer what this plugin does and what it can be used for?

"version": "1.0.0",
"min_version": "4.0.0",
"tags": ["animation", "keyframe", "workflow"],
"file": "posekey.js"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants