Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| }, | ||
| body: JSON.stringify(obj) | ||
| }) | ||
| const put = await response.json(); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.
| 'Content-Type': 'application/json' | ||
| }, | ||
| body: JSON.stringify(obj) | ||
| }) |
| 'defaultLibrary': document.getElementById('defaultLibrary').value | ||
| } | ||
|
|
||
| let response = await fetch(`/configuration/update/plex/library`, { |
There was a problem hiding this comment.
'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'template literal syntax' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
| 'key': key, | ||
| 'enabled': document.getElementById('libraryEnabled').value, | ||
| 'defaultLibrary': document.getElementById('defaultLibrary').value | ||
| } |
| } | ||
|
|
||
| export async function savePlexLibraryConfiguration(machineIdentifier, key) { | ||
| const obj = { |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| 'key': key | ||
| } | ||
| const plexLibraryButtonConfiguration = $("#plexLibraryButtonConfiguration").html(); | ||
| const theTemplate = Handlebars.compile(plexLibraryButtonConfiguration); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| const obj = { | ||
| 'machineIdentifier': machineIdentifier, | ||
| 'key': key | ||
| } |
| */ | ||
|
|
||
| export function openPlexLibraryConfigurationModel(machineIdentifier, key) { | ||
| const obj = { |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| * | ||
| */ | ||
|
|
||
| export function openPlexLibraryConfigurationModel(machineIdentifier, key) { |
There was a problem hiding this comment.
'export' is only available in ES6 (use 'esversion: 6').
| import {saveSchedule} from "./modules/schedule.min.js"; | ||
| import {getSoundOptions, savePushOverNotifications, testPushOverNotifications} from "./modules/push-over-notifications.min.js"; | ||
| import {saveDiscordNotifications, testDiscordNotifications} from "./modules/discord-notifications.min.js"; | ||
| import {openPlexLibraryConfigurationModel, savePlexLibraryConfiguration} from "./modules/plex-configuration.min.js" |
There was a problem hiding this comment.
'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.
| const plexLibraryModalTemplate = $("#plexLibraryModalTemplate").html(); | ||
| const theTemplate = Handlebars.compile(plexLibraryModalTemplate); | ||
| const theCompiledHtml = theTemplate(obj); | ||
| const plexLibraryConfigurationModal = document.getElementById('plexLibraryConfigurationModal'); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
| 'key': key | ||
| } | ||
| const plexLibraryModalTemplate = $("#plexLibraryModalTemplate").html(); | ||
| const theTemplate = Handlebars.compile(plexLibraryModalTemplate); |
There was a problem hiding this comment.
'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
JasonHHouse
force-pushed
the
improvement/default_library_and_disabled_library
branch
from
3b62c5d to
d6545d3
Compare
| .should('be.visible') | ||
| .and(($img) => { | ||
| // "naturalWidth" and "naturalHeight" are set when the image loads | ||
| expect($img[0].naturalWidth).to.be.greaterThan(0) |
|
|
||
| cy.get('.card-img') | ||
| .should('be.visible') | ||
| .and(($img) => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
| .should('be.visible') | ||
| .and(($img) => { | ||
| // "naturalWidth" and "naturalHeight" are set when the image loads | ||
| expect($img[0].naturalWidth).to.be.greaterThan(0) |
|
|
||
| cy.get('.card-img') | ||
| .should('be.visible') | ||
| .and(($img) => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
| .should('be.visible') | ||
| .and(($img) => { | ||
| // "naturalWidth" and "naturalHeight" are set when the image loads | ||
| expect($img[0].naturalWidth).to.be.greaterThan(0) |
|
|
||
| cy.get('.card-img') | ||
| .should('be.visible') | ||
| .and(($img) => { |
There was a problem hiding this comment.
'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
1 participant
In progress