Skip to content

chore: release#99

Closed
JayanAXHF wants to merge 5 commits intomainfrom
release-plz-2026-03-20T12-43-25Z
Closed

chore: release#99
JayanAXHF wants to merge 5 commits intomainfrom
release-plz-2026-03-20T12-43-25Z

Conversation

@JayanAXHF
Copy link
Owner

🤖 New release

  • ratatui-toaster: 0.1.1 -> 0.1.2 (✓ API compatible changes)
  • gitv-tui: 0.3.4 -> 0.3.5 (✓ API compatible changes)
Changelog

ratatui-toaster

0.1.1 - 2026-02-22

Other

  • (gitv-tui) release v0.3.0

gitv-tui

0.3.5 - 2026-03-20

Features

  • (preview pane) Add a small issue list preview when in issue conversation
  • (style) Revamp the entire UI to have less borders and distractions

Bug Fixes

  • (md) fixed checklist rendering

Other

  • cleanup fix(changelog): streamline changelog config in release-plz.toml
  • Add dependabot.yml
  • bump flake.lock, fix nitpick in drv, add .envrc

Testing

  • test fix(benches): make benches use std::hint::black_box


This PR was generated with release-plz.

JayanAXHF and others added 5 commits March 20, 2026 18:09
1. Removed a lot of unnecessary borders around elements.
2. Added line numbers for the input in issue conversation
3. Added a `BodyPreview` component that shows a preview of the issue
body in the TUI list widget.

test(ui): update tests

chore: fix lints

feat(style): migrate over issue_create

fix(style): remove old style borders for new ones in textarea previews

fix: fix bugs
…ersation

fix: render placeholder in create issue mode for convo preview
test(markdown): add UI tests for fixed list rendering
@JayanAXHF JayanAXHF closed this Mar 20, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 20, 2026

Greptile Summary

This is a release PR bumping gitv-tui from 0.3.4 → 0.3.5 and ratatui-toaster from 0.1.1 → 0.1.2. It delivers two features (new issue-conversation preview panel and a full UI border-reduction revamp), one bug fix (checklist markdown rendering), and miscellaneous housekeeping (benchmarks, testing helpers, lint-style refactors).

  • New IssueConvoPreview component (src/ui/components/issue_convo_preview.rs): adds a mini panel that shows the selected issue's body in list mode, or a 5-issue sliding window of nearby issues in details mode, with full keyboard navigation and action dispatch.
  • Markdown checklist fix (issue_conversation.rs): replaces the flat list_prefix: Option<String> with a structured ListPrefix that correctly differentiates task-list items ([ ]/[x]) from plain bullets and handles wrapped-line indentation alignment.
  • UI border revamp: most Block::bordered().border_type(Rounded) calls across issue_conversation, issue_create, issue_detail, issue_list, and label_list have been replaced with selective partial borders (Borders::LEFT, Borders::BOTTOM, etc.) combined with merge_borders(MergeStrategy::Exact) and Spacing::Overlap(1) in layouts, resulting in a cleaner, less noisy terminal UI.
  • Benches: criterion::black_box swapped for std::hint::black_box as the upstream-recommended opaque-use hint.
  • Layout split adjusted from 70/30 to 66/34 to accommodate the new preview panel column.
  • One misleading in-app message ("No preview available in fullscreen mode" shown on the CreateIssue screen) should be corrected.

Important Files Changed

Filename Overview
src/ui/components/issue_convo_preview.rs New component providing a mini preview panel showing either the issue body or a list of nearby issues. Contains a misleading "fullscreen mode" message shown in CreateIssue screen, and a block_template that is only partially reused.
src/ui/components/issue_conversation.rs Significant UI restyle (borders removed/simplified), checklist markdown bug-fix via new ListPrefix struct, and public exposure of render_markdown / MarkdownRender for the new preview component. Logic is sound.
src/ui/components/issue_list.rs Refactored list-item building into public helpers (build_issue_list_item, build_issue_list_lines), added sliding-window preview logic (build_details_preview_issue_ids), and wired up the new IssueListPreviewUpdated action. No issues found.
src/ui/components/issue_detail.rs Removed "Type" field (Issue/Pull Request distinction) and changed from rounded full-border block to a LEFT
src/ui/layout.rs Added mini_convo_preview area to the layout struct, changed main split from 70/30 to 66/34, and introduced Spacing::Overlap(1) to allow borders to merge cleanly between panels.
src/ui/mod.rs Registers the new IssueConvoPreview component (index 6) and adds two new Action variants (ChangeIssueBodyPreview, IssueListPreviewUpdated). Clean integration.
tests/markdown_checklists.rs New integration tests covering the checklist rendering fix: ASCII checkbox prefixes, wrapped continuations, and mixed checked/unchecked lists. Well structured.
benches/ui_hotspots.rs Switches from criterion::black_box (deprecated) to std::hint::black_box as the canonical opaque-use hint. Correct change.
src/ui/components/status_bar.rs Minor typo fix: added missing closing > to the quit keybind display string (q/&lt;C-q>/&lt;C-c>).

Sequence Diagram

sequenceDiagram
    participant IL as IssueList
    participant IP as IssueConvoPreview
    participant IC as IssueConversation
    participant ID as IssueDetail

    IL->>IL: User selects issue (Enter)
    IL->>IP: Action::ChangeIssueBodyPreview(body)
    IL->>ID: Action::SelectedIssuePreview(seed)
    IL->>IP: Action::IssueListPreviewUpdated(issue_ids, selected_number)
    IL->>IC: Action::EnterIssueDetails(seed)

    Note over IP: screen == List → show body preview
    Note over IP: screen == Details → show nearby issues list

    IP->>IP: User presses Enter on nearby issue
    IP->>IL: Action::SelectedIssue(number, labels)
    IP->>ID: Action::SelectedIssuePreview(seed)
    IP->>IP: Action::IssueListPreviewUpdated(issue_ids, selected_number)
    IP->>IC: Action::EnterIssueDetails(seed)
Loading

Comments Outside Diff (2)

  1. src/ui/components/issue_convo_preview.rs, line 575-576 (link)

    P1 Misleading error message for CreateIssue screen

    The string "No preview available in fullscreen mode" is displayed when self.screen == MainScreen::CreateIssue, but the message incorrectly references "fullscreen mode". Fullscreen mode is a separate variant (MainScreen::DetailsFullscreen). A user creating an issue would see this text and be confused about why it says "fullscreen".

  2. src/ui/components/issue_convo_preview.rs, line 589-612 (link)

    P2 block_template partially unused

    block_template is constructed at line 590 but only used in the empty-body branch (via block_template.title(...).merge_borders(...)). When a body is present, a completely different Block is constructed from scratch (lines 607–612), making the block_template variable misleadingly named and partially dead. Consider either building the full block from block_template in both branches, or inlining the block at the call site for the no-body case to make the intent explicit.

Last reviewed commit: "chore: release"

Comment on lines +29 to 30
- test fix(benches): make benches use `std::hint::black_box`
## [0.3.4] - 2026-03-08
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Missing blank line between changelog sections

The new 0.3.5 section ends without a blank line before the ## [0.3.4] heading. Keep-a-Changelog format requires a blank line between ## entries for proper rendering on GitHub/crates.io.

Suggested change
- test fix(benches): make benches use `std::hint::black_box`
## [0.3.4] - 2026-03-08
- test fix(benches): make benches use `std::hint::black_box`
## [0.3.4] - 2026-03-08

@JayanAXHF JayanAXHF deleted the release-plz-2026-03-20T12-43-25Z branch March 20, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant