feat: support longer space names with dynamic icon widths and improved contrast#51
Open
Nicomalacho wants to merge 1 commit intoJaysce:mainfrom
Open
feat: support longer space names with dynamic icon widths and improved contrast#51Nicomalacho wants to merge 1 commit intoJaysce:mainfrom
Nicomalacho wants to merge 1 commit intoJaysce:mainfrom
Conversation
…d contrast - Increase space name limit from 3 to 10 characters in preferences UI - Dynamically size menu bar icons based on text content instead of fixed 49px - Improve named spaces rendering: filled background for active space, bordered with visible text for inactive spaces - Update default fullscreen app name truncation to 10 characters - Use variable icon widths in mergeIcons for proper layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The 3-character name limit is quite restrictive — users can't write readable labels like "Slack", "Browser", or "Terminal". This PR raises the limit to 10 characters and makes the rendering adapt to variable-length names.
The contrast improvement addresses poor readability of inactive space names, which were nearly invisible against certain menu bar backgrounds due to the
destinationOutcompositing on thin border icons.Changes
PreferencesView.swift.prefix(3)→.prefix(10), updated placeholder textSpaceObserver.swift.prefix(3)→.prefix(10)IconCreator.swiftcreateNamedIconsrendering with filled/bordered styles, variable-widthmergeIconslayoutScreenshots
Tested on macOS Tahoe 26.2 with 16 spaces using full-word names (Slack, Monitor, Dev, Browser, etc.)