ClrDynamic implements IConvertible explicitly#23
Open
fbrosseau wants to merge 1 commit intoJeffCyr:masterfrom
Open
ClrDynamic implements IConvertible explicitly#23fbrosseau wants to merge 1 commit intoJeffCyr:masterfrom
fbrosseau wants to merge 1 commit intoJeffCyr:masterfrom
Conversation
Contributor
fbrosseau
commented
Feb 5, 2019
fbrosseau
commented
- ClrDynamic implements IConvertible
- Also compacted the boilerplate code of explicit casts with expression bodies
Also compacted the boilerplate code of explicit casts with expression bodies
JeffCyr
requested changes
Feb 5, 2019
Owner
JeffCyr
left a comment
JeffCyr
left a comment
There was a problem hiding this comment.
Thanks for those changes, looks good after those two small changes are done
| AddType(typeof(DnsEndPoint)); | ||
| AddType(typeof(X509Certificate)); | ||
| AddType(typeof(X509Certificate2)); | ||
| } |
Owner
There was a problem hiding this comment.
IPEndPoint/DnsEndPoint/X509Certificate/X509Certificate2 should not be there
| AddType(typeof(X509Certificate2)); | ||
| } | ||
|
|
||
| public static Type GetRealType(this ClrType type) |
Owner
There was a problem hiding this comment.
I don't think this method needs to exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.