feat: add email notification toggle to DoneScreen#8796
feat: add email notification toggle to DoneScreen#8796
Conversation
Create ScreenWrapper component with responsive title/subtitle and migrate all 6 customization screens to use it. Fixes MediaScreen using wrong Typography variants and broken color prop. Refs: NES-1364 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Eliminate the headerSx prop from DoneScreen, LanguageScreen, LinksScreen, and ScreenWrapper components to streamline the code. Update TextScreen to maintain consistent mobileSubtitle formatting.
Refs: NES-1295 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
edmonday
changed the base branch from
main
to
edmondshen/nes-1364-media-screen-styling-changes
|
View your CI Pipeline Execution ↗ for commit 7ef0dd6 ☁️ Nx Cloud last updated this comment at |
…edmondshen/nes-1295-toggle-email-notifications-on-for-a-journey
…edmondshen/nes-1295-toggle-email-notifications-on-for-a-journey
…edmondshen/nes-1295-toggle-email-notifications-on-for-a-journey
1 participant
Summary
NotificationSwitchTooltip conditional — only renders whennameprop is providedDoneScreenVerification
pnpm run build: passedNotificationSwitch.spec.tsx: 4/4 passedDoneScreen.spec.tsx: 9/9 passedFiles changed
NotificationSwitch.tsx— conditional Tooltip renderingNotificationSwitch.spec.tsx— new test for no-Tooltip caseDoneScreen.tsx— notification section UIDoneScreen.spec.tsx— 3 new tests for notification sectionRefs: NES-1295