chore: update firebase and related dependencies to latest versions by mikeallisonJS · Pull Request #8899 · JesusFilm/core

mikeallisonJS · 2026-03-23T21:29:05Z

Summary by CodeRabbit

Chores
- Updated Firebase library dependency to the latest compatible major version.
Tests
- Added test environment polyfills to improve JSDOM/Node compatibility.
- Adjusted test initialization order so polyfills load before existing test setup.

coderabbitai · 2026-03-23T21:29:12Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7e5b9899-6988-4b80-aaeb-ddc57ce42151

📥 Commits

Reviewing files that changed from the base of the PR and between 6297b15 and 893dd7f.

📒 Files selected for processing (2)

apps/videos-admin/jest.config.ts
apps/videos-admin/jest.polyfills.js

Walkthrough

Bumps Firebase dependency in package.json to ^10.0.0, and adds a Jest polyfills file plus a setupFiles entry to apps/videos-admin/jest.config.ts to load Node/Web globals and undici fetch APIs for tests.

Changes

Cohort / File(s)	Summary
Dependency Update `package.json`	Updated Firebase dependency from `^9.16.0` to `^10.0.0`.
Test config `apps/videos-admin/jest.config.ts`	Added `setupFiles` entry pointing to `./jest.polyfills.js` so polyfills run before existing `setupFilesAfterEnv`.
Jest polyfills `apps/videos-admin/jest.polyfills.js`	New file that defines `globalThis` entries: `TextDecoder`, `TextEncoder`, `ReadableStream`, and exposes undici `fetch`, `Headers`, `FormData`, `Request`, `Response` for Jest tests.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title mentions updating Firebase and related dependencies, but the actual changes include Jest polyfill setup modifications beyond just dependency updates.	Clarify whether the title should emphasize both dependency updates and Jest configuration changes, or if the jest.polyfills.js setup is a supporting change for the Firebase upgrade.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 00-00-MA-chore-firebase-10

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-23T21:30:24Z

View your CI Pipeline Execution ↗ for commit 893dd7f

Command	Status	Duration	Result
`nx run journeys-admin-e2e:e2e`	✅ Succeeded	30s	View ↗
`nx run journeys-e2e:e2e`	✅ Succeeded	24s	View ↗
`nx run resources-e2e:e2e`	✅ Succeeded	27s	View ↗
`nx run watch-e2e:e2e`	✅ Succeeded	25s	View ↗
`nx run short-links-e2e:e2e`	✅ Succeeded	3s	View ↗
`nx run watch-modern-e2e:e2e`	✅ Succeeded	4s	View ↗
`nx run videos-admin-e2e:e2e`	✅ Succeeded	4s	View ↗
`nx run docs-e2e:e2e`	✅ Succeeded	3s	View ↗
`Additional runs (28)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-23 22:03:04 UTC

github-actions · 2026-03-23T21:30:24Z

	Warnings
⚠️	❗ Big PR (750 changes)

(change count - 750): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against 893dd7f

github-actions · 2026-03-23T21:33:08Z