fix: filter deleted blocks from adminJourney query#8902
fix: filter deleted blocks from adminJourney query#8902
Conversation
The blocks relation on Journey type in api-journeys-modern was returning all blocks including soft-deleted ones (deletedAt != null). The legacy api-journeys resolver correctly filtered these out. This aligns the new API with the old behavior and with other block queries in the codebase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit b179485
☁️ Nx Cloud last updated this comment at |
|
I see you added the "on stage" label, I'll get this merged to the stage branch! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
blocksrelation on the Journey type inapi-journeys-modernwas returning all blocks including soft-deleted ones (deletedAt != null)api-journeysresolver correctly filtered these withdeletedAt: null— this was missed during the portquery: () => ({ where: { deletedAt: null } })to theblocksrelation, consistent with all other block queries in the codebaseTest plan
adminJourneyquery no longer returns blocks with non-nulldeletedAt🤖 Generated with Claude Code
Summary by CodeRabbit