fix(web): quiz button full width at xs and sm viewports#496
Open
Kneesal wants to merge 2 commits intoJesusFilm:mainfrom
Open
fix(web): quiz button full width at xs and sm viewports#496Kneesal wants to merge 2 commits intoJesusFilm:mainfrom
Kneesal wants to merge 2 commits intoJesusFilm:mainfrom
Conversation
Change sm:w-auto to md:w-auto so the button stays 100% width through the sm breakpoint and only shrinks at md and above. Resolves JesusFilm#495 Made-with: Cursor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughChanged Tailwind responsive width on the QuizButton wrapper from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Drop px-6 from the QuizButton wrapper so it inherits the parent Section's px-4/sm:px-8/lg:px-10 padding at xs and sm viewports, keeping the button edges aligned with sibling content. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sm:w-autotomd:w-autoso the button remains full-width (100%) at xs and sm viewports and only shrinks at md and above.Contracts Changed
No
Regeneration Required
No
Validation
w-fullapplies by default,md:w-autokicks in at 768px+, and lg/xl/2xl sizing is unchanged.Resolves #495
Made with Cursor
Summary by CodeRabbit