Open
Conversation
Contributor
Author
|
Waiting on release from DCE |
…h-logging # Conflicts: # src/databao_cli/commands/build.py # src/databao_cli/shared/log/cli_progress.py
The original implementation imported from a non-existent databao_context_engine.progress module and passed an unsupported `progress` parameter to build_context(), making the build command crash. Rewrote cli_progress to intercept library log messages for per-datasource progress tracking via Rich. Added progress to the index command. Added 8 unit tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
the current |
gasparian
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a progress UI for the
buildcommand.The progress display focuses on:
How it works
buildandindexemit structured progress events while runningCLI progress rendering
Adds a
cli_progress()renderer for interactive terminal. When the terminal is non-interactive, the progress callback becomes a no-op.Step based datasource progress
The datasource progress model is intentionally high-level, based only on meaningful, potentially long running steps. Each datasource has the following steps:
Logging conflicts
While the progress UI is active, console logging from both
databao_context_engineanddatabao_cliis routed through a shared handler, so the log output does not corrupt the live display. This is scoped to the rich progress context and restores the previous logger configuration afterwards.Notes
The overall progress bar looks better if the logs from either
databao_context_engineanddatabao_cliare not printed during execution. These logs can be stored, and printed after the execution only, possibly creating a better user experience. However, I would like for that to be discussed before applying such a change.Screen.Recording.2026-03-11.at.11.51.46.mov