ant: Use JavaVersion condition over regex for Java 17 checks#42
Open
Awakened-Redstone wants to merge 1 commit intoJetBrains:devfrom
Open
ant: Use JavaVersion condition over regex for Java 17 checks#42Awakened-Redstone wants to merge 1 commit intoJetBrains:devfrom
Awakened-Redstone wants to merge 1 commit intoJetBrains:devfrom
Conversation
The regex check 17*.* fails for Java 20 and newer and doesn't check for Java 17, but any version that starts with a 1, which includes 1.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the version check for adding required modules to the JVM arguments.
The current check for the condition is a regex match, with it being
17*.*, which, effectively, matches every version with a 1 in any position.The regex fails on versions past Java 20 that doesn't contain a 1, such as Java 25.0.2
This pushes the minimum ant required version to 1.10.2, but with 1.9.x being EOL, it shouldn't pose issues
Fixes #40