New rectangle methods for retrieving edges#197
Open
Ivan Kupriyanov (IKupriyanov-HORIS) wants to merge 5 commits into
Open
New rectangle methods for retrieving edges#197Ivan Kupriyanov (IKupriyanov-HORIS) wants to merge 5 commits into
Ivan Kupriyanov (IKupriyanov-HORIS) wants to merge 5 commits into
Conversation
| ); | ||
| } | ||
|
|
||
| public Iterable<DoubleSegment> getParts() { |
Contributor
There was a problem hiding this comment.
I would use List here
| result.add(new DoubleSegment(origin, origin.add(new DoubleVector(0, dimension.y)))); | ||
| result.add(new DoubleSegment(origin.add(dimension), origin.add(new DoubleVector(dimension.x, 0)))); | ||
| result.add(new DoubleSegment(origin.add(dimension), origin.add(new DoubleVector(0, dimension.y)))); | ||
| result.add(getTopEdge()); |
Contributor
There was a problem hiding this comment.
I would use Arrays.asList(..) instead.
| public void getParts() { | ||
| Iterator<DoubleSegment> edges = RECTANGLE.getParts().iterator(); | ||
|
|
||
| assertEquals(TOP_EDGE, edges.next()); |
Contributor
There was a problem hiding this comment.
I would use something like assertEquals(Arrays.asList(...), edges)
Contributor
|
Timur Zambalayev (@timzam) Could you review it further and merge depending on your opinion of the code. |
Konstantin Solomatov (solomatov)
requested a review
from Timur Zambalayev (timzam)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.