Skip to content

[gfm] Fix the HTML generation for tables inside quotes #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikola-kocic-jetbrains wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[gfm] Fix the HTML generation for tables inside quotes #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/commonMain/kotlin/org/intellij/markdown/flavours/gfm/GFMGeneratingProviders.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ internal class TablesGeneratingProvider : GeneratingProvider {
val cells = SPLIT_REGEX.split(separatorRow.getTextInNode(text))
for (i in cells.indices) {
val cell = cells[i]
if (!cell.isBlank() || i in 1..cells.lastIndex - 1) {
if (i in 1..cells.lastIndex - 1 || cell.contains('-')) {
val trimmed = cell.trim()
val starts = trimmed.startsWith(':')
val ends = trimmed.endsWith(':')
Expand Down
5 changes: 5 additions & 0 deletions src/fileBasedTest/kotlin/org/intellij/markdown/HtmlGeneratorCommonTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@ class HtmlGeneratorCommonTest : HtmlGeneratorTestBase() {
defaultTest(GFMFlavourDescriptor())
}

@Test
fun testTableInsideBlockQuoteWithMissingLastPipe() {
defaultTest(GFMFlavourDescriptor())
}

@Test
fun testCheckedLists() {
defaultTest(GFMFlavourDescriptor())
Expand Down
5 changes: 5 additions & 0 deletions src/fileBasedTest/resources/data/html/tableInsideBlockQuoteWithMissingLastPipe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
> | Table | Frezze | Bug |
> | --- | ------ | ---- |
> | foo | some | fix |
> | bar | item | plz
|
26 changes: 26 additions & 0 deletions src/fileBasedTest/resources/data/html/tableInsideBlockQuoteWithMissingLastPipe.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<body>
<blockquote>
<table>
<thead>
<tr>
<th>Table</th>
<th>Frezze</th>
<th>Bug</th>
</tr>
</thead>
<tbody>
<tr>
<td>foo</td>
<td>some</td>
<td>fix</td>
</tr>
<tr class="intellij-row-even">
<td>bar</td>
<td>item</td>
<td>plz</td>
</tr>
</tbody>
</table>
</blockquote>
<p>|</p>
</body>