🔥 QD-14791 QD-14813 Remove implicit scan injection from CLI dispatch - #962
Open
Anna Zhukova (bindreams) wants to merge 2 commits into
Open
🔥 QD-14791 QD-14813 Remove implicit scan injection from CLI dispatch#962Anna Zhukova (bindreams) wants to merge 2 commits into
Anna Zhukova (bindreams) wants to merge 2 commits into
Conversation
Qodana for Go115 new problems were found
@@ Code coverage @@
+ 65% total lines covered
10639 lines analyzed, 6935 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Anna Zhukova (bindreams)
changed the title
Anna Zhukova (bindreams)
marked this pull request as ready for review
May 27, 2026 11:56
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1bc21cb358
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
|
This pull request has been automatically marked as stale because it has not had recent activity for 7 days. What happens next?
Thank you for your contribution! 🙏 |
|
This pull request has been automatically closed due to inactivity. Don't worry! You can always:
Thank you for your contribution! 🙏 |
Alexey Afanasiev (avafanasiev)
force-pushed
the
azhukova/QD-14791
branch
from
July 27, 2026 08:47
1bc21cb to
f74df16
Compare
Qodana for Go115 new problems were found
@@ Code coverage @@
+ 65% total lines covered
10603 lines analyzed, 6943 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
|
This pull request has been automatically marked as stale because it has not had recent activity for 7 days. What happens next?
Thank you for your contribution! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
setDefaultCommandIfNeededlayer ininternal/cmd/root.gothat silently rewroteqodana <args>toqodana scan <args>when args didn't match a hand-rolled list of known invocations. After this PR, cobra's standard subcommand resolution handles every invocation.This is a deliberate, product-approved removal — broader than a narrow patch to QD-14791 alone.
Why
The injection was added in November 2023 to make
qodana -i .work as a shorthand forqodana scan -i .. It has produced a recurring class of UX bugs over 2+ years:qodana completionran scan. Patched narrowly.qodana help completionruns scan. Same root cause as QD-9907; the 2024 patch didn't generalize. This is the bug the PR fixes.qodana pullauto-promoted to scan. Won't-fix.__complete/__completeNoDesc(used by shell completion scripts at every Tab press) were silently misrouted to scan.qodana -i scanwas misread because the oldisCommandRequestedscanned the entire argv for command names.The dispatch layer saved five keystrokes and has cost the team multiple bug reports. Time to retire it.
Tickets
qodana help completionruns scan.Behavior changes (breaking)
qodana help completionqodana <Tab>(shell completion)qodanaqodana -i .-i .-iqodana --linter qodana-jvmqodana scan -i .qodana <known-subcommand> [args]qodana -v/--version/-h/--helpSee QD-14813 for the full table and migration cookbook (TL;DR: anywhere you had
qodana <flags>, writeqodana scan <flags>).Diff
internal/cmd/root.go: −32 lines. DeletesisHelpOrVersion,isCompletionRequested,isCommandRequested,setDefaultCommandIfNeeded, the call site inExecute(), and theslicesimport.Execute()collapses to the warning + update check +rootCommand.Execute().internal/cmd/cmd_test.go: refactor. Deletes the four obsolete helper tests. AddsdispatchTestRoot()test helper and six dispatch tests covering the QD-14791 bug, the QD-9907 prior-art path, cobra's hidden__complete, bare invocation, unknown subcommand, and the latent scan flag-value collision.TDD trail
Two commits, deliberately structured to make TDD visible:
da649ecdaddsTestQD14791HelpCompletionDispatchwith an explicitsetDefaultCommandIfNeeded(...)call that demonstrates the bug. The test fails on this commit (scan runs instead of help dispatch).1bc21cb3deletes the dispatch helpers and the call site. The keystone test loses itssetDefaultCommandIfNeededline (now undefined) and passes against cobra-native dispatch. Adds five additional post-removal dispatch tests.CI on commit 1 in isolation would surface the failing test (the regression the fix addresses). CI on the branch HEAD (commit 2) is green.
Test plan
go test ./internal/cmd/...— all tests pass.