fix: Enhance external image fallback reliability and prevent endless error loops - #8983
Open
Aditya8369 wants to merge 1 commit into
Open
fix: Enhance external image fallback reliability and prevent endless error loops#8983Aditya8369 wants to merge 1 commit into
Aditya8369 wants to merge 1 commit into
Conversation
…tes src without guarding
Contributor
|
@Aditya8369 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request addresses issues with the external image fallback mechanism by implementing a guard to prevent endless error loops and ensuring that fallback attempts are tracked. This aligns with previous decisions made to enhance user experience by preventing invalid fallback URLs. The addition of unit tests further strengthens the reliability of this feature. Thank you for your contribution! |
retenta-bot
Bot
changed the title
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Guarded Fallback Attempt: Updated onError in
LandingPageClient.tsx
to mark img.dataset.fallbackAttempted = 'true' when an avatar image fails to load.
Prevented Endless Error Loops: When fallbackAttempted is already 'true' (or when src is already the fallback URL and fails), the handler sets img.style.display = 'none' and stops modifying src.
Unit Testing: Added unit tests in
LandingPageClient.avatar-fallback.test.tsx
verifying single fallback attempt behavior and UI stabilization.
closes #3607