Fix Security Vulnerability by Validating AUTH_SECRET and ENCRYPTION_KEY - #8989
Open
Rakshak05 wants to merge 2 commits into
Open
Fix Security Vulnerability by Validating AUTH_SECRET and ENCRYPTION_KEY#8989Rakshak05 wants to merge 2 commits into
Rakshak05 wants to merge 2 commits into
Conversation
Contributor
|
@Rakshak05 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This PR addresses a critical security issue by ensuring that fallback keys are not used, which could lead to cryptographic vulnerabilities. It's similar to previous decisions made to enhance user experience and security, such as fixing theme rendering based on system preferences. Thank you for your contribution, and I look forward to your updates! |
retenta-bot
Bot
changed the title
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7718
Enforces strict environment variable validation for
AUTH_SECRET(andENCRYPTION_KEY) inlib/validate-env.ts. Server startup (instrumentation.ts) will now fail loudly with an explicit error message if default or fallback secret strings (such as'fallback-secret') are set in the environment, preventing cryptographic key exposure and session hijacking risks.Pillar
Visual Preview
N/A (Server startup security environment validation)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.