Fix Security Issues in GitHub API Error Handling and Enforce Refresh Cooldown - #8990
Open
Rakshak05 wants to merge 2 commits into
Open
Fix Security Issues in GitHub API Error Handling and Enforce Refresh Cooldown#8990Rakshak05 wants to merge 2 commits into
Rakshak05 wants to merge 2 commits into
Conversation
Contributor
|
@Rakshak05 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request addresses important security concerns by sanitizing error responses from the GitHub API and implementing a cooldown mechanism for refresh requests. This aligns with our previous decision to handle rate limits gracefully in the /api/streak endpoint, ensuring a better user experience. Thank you for your contributions, and I look forward to your updates! |
…y test expectation
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7279
lib/github.tsby logging raw error metadata server-side only and returning generic error messages to prevent leaking PAT identity, scopes, or rate limits to clients.buildErrorResponseinapp/api/streak/route.tsto return a standardized typed error JSON shape{ error: "upstream_failure", code: "GITHUB_API_ERROR" }for 500 status upstream failures.?refresh=truecache-bypass requests inRefreshPolicy, configurable viaREFRESH_COOLDOWN_MS.SECURITY.mdto explicitly documentread:userscope requirements and fine-grained PAT recommendations for self-hosters.Pillar
Visual Preview
N/A (Backend security, error handling, and rate limiting optimization)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.